Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2154913002: Flip for writing mode exactly along the containing block chain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: none Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 6b443a587a2ce3eacddf7d97d75734b7ee46f0d8..84d95c539f0de1187da31b7732e33acaa04c9d78 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -2043,11 +2043,9 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ances
bool ancestorSkipped;
bool filterOrReflectionSkipped;
LayoutObject* container = this->container(ancestor, &ancestorSkipped, &filterOrReflectionSkipped);
- LayoutBox* localContainingBlock = containingBlock();
// Skip table row because cells and rows are in the same coordinate space, except when we're already at the ancestor.
if (container->isTableRow() && container != ancestor) {
DCHECK(isTableCell());
- localContainingBlock = toLayoutBox(container->parent());
container = container->parent();
}
if (!container)
@@ -2067,8 +2065,8 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ances
LayoutPoint topLeft = rect.location();
// TODO(wkorman): Look into and document why this conditional is needed.
// Currently present following logic in PaintLayer::updateLayerPosition.
- if (!(isInline() && isLayoutInline()))
- topLeft.moveBy(topLeftLocation(localContainingBlock));
+ if (container->isBox())
wkorman 2016/07/18 23:21:28 Interested to discuss in person when you are free.
chrishtr 2016/07/18 23:26:57 There were three failing SVG tests, because now th
+ topLeft.moveBy(topLeftLocation(toLayoutBox(container)));
const ComputedStyle& styleToUse = styleRef();
EPosition position = styleToUse.position();

Powered by Google App Engine
This is Rietveld 408576698