Flip for writing mode exactly along the containing block chain.

Flip for writing mode exactly along the containing block chain.

container() actually implements containg block. (Contrary to the name
containingBlock() in the other method, it implements something slightly different.)

BUG=616600
Committed: https://crrev.com/cac5d64bc07cde6d153ee9c7c9e6367aa07f3c39
Cr-Commit-Position: refs/heads/master@{#406177}

[chrishtr, 2016-07-15 22:04:51]

Description was changed from

==========
none

BUG=
==========

to

==========
Don't flip for writing mode in LayoutInline.

BUG=616600
==========

[chrishtr, 2016-07-15 22:04:57]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2016-07-15 22:05:04]

chrishtr@chromium.org changed reviewers:
+ wkorman@chromium.org

[commit-bot: I haz the power, 2016-07-15 22:05:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 23:12:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 23:12:55]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[chrishtr, 2016-07-18 17:43:33]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 17:44:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-07-18 17:44:24]

fast/repaint/selection-rl.html was failing because it has a LayoutText with a
LayoutInline parent. The code for LayoutText would not flip because its parent
was not a block.
I changed the code to flip w.r.t. the containing block, we'll see if that passes
all the
tests.

[commit-bot: I haz the power, 2016-07-18 19:15:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 19:15:33]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-07-18 19:45:28]

Description was changed from

==========
Don't flip for writing mode in LayoutInline.

BUG=616600
==========

to

==========
Don't flip for writing mode in LayoutInline. Instead, flip directly on the
LayoutText that is at the bottom of an inline subtree.

BUG=616600
==========

[wkorman, 2016-07-18 20:49:37]

lgtm

[chrishtr, 2016-07-18 20:49:41]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 20:50:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-07-18 20:50:56]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-07-18 20:50:57]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-07-18 20:51:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-07-18 21:19:57]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-07-18 22:04:48]

Description was changed from

==========
Don't flip for writing mode in LayoutInline. Instead, flip directly on the
LayoutText that is at the bottom of an inline subtree.

BUG=616600
==========

to

==========
Flip for writing mode exactly along the containing block chain.

container() actually implements containg block. (Contrary to the name
containingBlock() in the other method, it implements something slightly
different.)

BUG=616600
==========

[chrishtr, 2016-07-18 22:05:21]

Reworked to just use container()'s chain instead of containingBlock. I think
using
containingBlock was a mistake.

[chrishtr, 2016-07-18 22:05:22]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-18 22:05:22]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2154913002/#ps80001
(title: "none")

[commit-bot: I haz the power, 2016-07-18 22:06:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 23:14:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 23:14:56]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[wkorman, 2016-07-18 23:21:28]

lgtm

https://codereview.chromium.org/2154913002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2154913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2068: if
(container->isBox())
Interested to discuss in person when you are free.

https://codereview.chromium.org/2154913002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2154913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1583: }
nit: don't need the curlies

[chrishtr, 2016-07-18 23:26:57]

https://codereview.chromium.org/2154913002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2154913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2068: if
(container->isBox())
On 2016/07/18 at 23:21:28, wkorman wrote:
> Interested to discuss in person when you are free.

There were three failing SVG tests, because now they fail to adjust by
locationOffset() Now I changed it to

if (box)
  adjust by location offset including flipping
else
  adjust by location offset

https://codereview.chromium.org/2154913002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2154913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1583: }
On 2016/07/18 at 23:21:28, wkorman wrote:
> nit: don't need the curlies

Removed.

[chrishtr, 2016-07-18 23:27:11]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2016-07-18 23:27:19]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-07-18 23:27:21]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-18 23:27:21]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2154913002/#ps120001
(title: "none")

[commit-bot: I haz the power, 2016-07-18 23:28:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 01:56:48]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-19 02:00:46]

Description was changed from

==========
Flip for writing mode exactly along the containing block chain.

container() actually implements containg block. (Contrary to the name
containingBlock() in the other method, it implements something slightly
different.)

BUG=616600
==========

to

==========
Flip for writing mode exactly along the containing block chain.

container() actually implements containg block. (Contrary to the name
containingBlock() in the other method, it implements something slightly
different.)

BUG=616600

Committed: https://crrev.com/cac5d64bc07cde6d153ee9c7c9e6367aa07f3c39
Cr-Commit-Position: refs/heads/master@{#406177}
==========

[commit-bot: I haz the power, 2016-07-19 02:00:48]

Patchset 7 (id:??) landed as
https://crrev.com/cac5d64bc07cde6d153ee9c7c9e6367aa07f3c39
Cr-Commit-Position: refs/heads/master@{#406177}