DevTools: remove isTrusted check and isUserGesture from ViewportControl

third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 362 matching lines @@
 
         selection.setBaseAndExtent(anchorElement, anchorOffset, headElement, headOffset);
     },
 
     refresh: function()
     {
         this._innerRefresh(false);
     },
 
     /**
-     * @param {boolean} isUserGesture
+     * @param {boolean} isScroll
      */
-    _innerRefresh: function(isUserGesture)
+    _innerRefresh: function(isScroll)

[lushnikov, 2016/07/19 00:19:49]

let's just remove this argument altogether

     {
         if (!this._visibleHeight())
             return;  // Do nothing for invisible controls.
 
         if (!this._itemCount) {
             for (var i = 0; i < this._renderedItems.length; ++i)
                 this._renderedItems[i].willHide();
             this._renderedItems = [];
             this._contentElement.removeChildren();
             this._topGapElement.style.height = "0px";
@@ skipping 13 matching lines @@
 
         for (var i = 0; i < this._renderedItems.length; ++i) {
             // Tolerate 1-pixel error due to double-to-integer rounding errors.
             if (this._cumulativeHeights && Math.abs(this._cachedItemHeight(this._firstVisibleIndex + i) - this._renderedItems[i].element().offsetHeight) > 1)
                 delete this._cumulativeHeights;
         }
         this._rebuildCumulativeHeightsIfNeeded();
         var oldFirstVisibleIndex = this._firstVisibleIndex;
         var oldLastVisibleIndex = this._lastVisibleIndex;
 
-        var shouldStickToBottom = !isUserGesture && this._stickToBottom && this._scrolledToBottom;
+        var shouldStickToBottom = this._stickToBottom && this._scrolledToBottom;
 
         if (shouldStickToBottom) {
             this._lastVisibleIndex = this._itemCount - 1;
             this._firstVisibleIndex = Math.max(this._itemCount - Math.ceil(visibleHeight / this._provider.minimumRowHeight()), 0);
+
+            if (isScroll)
+                this._firstVisibleIndex = Math.max(Array.prototype.lowerBound.call(this._cumulativeHeights, visibleFrom + 1), 0);

[lushnikov, 2016/07/19 00:19:49]

let's kill this - viewport control should work fine without these lines

         } else {
             this._firstVisibleIndex = Math.max(Array.prototype.lowerBound.call(this._cumulativeHeights, visibleFrom + 1), 0);
             // Proactively render more rows in case some of them will be collapsed without triggering refresh. @see crbug.com/390169
             this._lastVisibleIndex = this._firstVisibleIndex + Math.ceil(visibleHeight / this._provider.minimumRowHeight()) - 1;
             this._lastVisibleIndex = Math.min(this._lastVisibleIndex, this._itemCount - 1);
         }
         var topGapHeight = this._cumulativeHeights[this._firstVisibleIndex - 1] || 0;
         var bottomGapHeight = this._cumulativeHeights[this._cumulativeHeights.length - 1] - this._cumulativeHeights[this._lastVisibleIndex];
 
         /**
@@ skipping 127 matching lines @@
         while ((node = node.traverseNextTextNode()) && node !== container)
             chars += node.textContent.length;
         return chars + offset;
     },
 
     /**
      * @param {!Event} event
      */
     _onScroll: function(event)
     {
-        this._innerRefresh(event.isTrusted);
+        this._innerRefresh(true);
     },
 
     /**
      * @return {number}
      */
     firstVisibleIndex: function()
     {
         return this._firstVisibleIndex;
     },
 
@@ skipping 55 matching lines @@
 
     /**
      * @return {number}
      */
     _visibleHeight: function()
     {
         // Use offsetHeight instead of clientHeight to avoid being affected by horizontal scroll.
         return this.element.offsetHeight;
     }
 }