DevTools: remove isTrusted check and isUserGesture from ViewportControl

DevTools: remove isTrusted check and isUserGesture from ViewportControl

Previously, the ViewportControl never stuck to the bottom after a scroll event.
The event.isTrusted check was always true, so it was not correctly
distinguishing user-generated scroll events from script-generated ones.  This
CL removes isUserGesture accordingly.

BUG=613879
Committed: https://crrev.com/2dbbaccdef5a4b1f1348792a8b5be93e58507d33
Cr-Commit-Position: refs/heads/master@{#407062}

[luoe, 2016-07-16 02:28:12]

Description was changed from

==========
DevTools: isTrusted check for scroll events removed from viewportControl

BUG=613879
==========

to

==========
DevTools: remove isTrusted check and isUserGesture from ViewportControl

Previously, the ViewportControl never stuck to the bottom after a scroll event.
The event.isTrusted check was always true, so it was not correctly
distinguishing user-generated scroll events from script-generated ones.  This
CL replaces isUserGesture accordingly.

BUG=613879
==========

[luoe, 2016-07-16 02:28:28]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2016-07-18 16:34:40]

We could update our tests to check this behavior.  Coming soon.

[lushnikov, 2016-07-19 00:19:50]

https://codereview.chromium.org/2154893002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js (right):

https://codereview.chromium.org/2154893002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js:385:
_innerRefresh: function(isScroll)
let's just remove this argument altogether

https://codereview.chromium.org/2154893002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js:426:
this._firstVisibleIndex =
Math.max(Array.prototype.lowerBound.call(this._cumulativeHeights, visibleFrom +
1), 0);
let's kill this - viewport control should work fine without these lines

[lushnikov, 2016-07-19 02:26:19]

https://codereview.chromium.org/2154893002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js (right):

https://codereview.chromium.org/2154893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js:385:
_innerRefresh: function(isScroll)
we can now remove this argument altogether

[luoe, 2016-07-19 17:48:44]

Description was changed from

==========
DevTools: remove isTrusted check and isUserGesture from ViewportControl

Previously, the ViewportControl never stuck to the bottom after a scroll event.
The event.isTrusted check was always true, so it was not correctly
distinguishing user-generated scroll events from script-generated ones.  This
CL replaces isUserGesture accordingly.

BUG=613879
==========

to

==========
DevTools: remove isTrusted check and isUserGesture from ViewportControl

Previously, the ViewportControl never stuck to the bottom after a scroll event.
The event.isTrusted check was always true, so it was not correctly
distinguishing user-generated scroll events from script-generated ones.  This
CL removes isUserGesture accordingly.

BUG=613879
==========

[luoe, 2016-07-19 17:52:33]

Removed argument from innerRefresh() and changed it to refresh().

https://codereview.chromium.org/2154893002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js (right):

https://codereview.chromium.org/2154893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js:385:
_innerRefresh: function(isScroll)
On 2016/07/19 02:26:19, lushnikov wrote:
> we can now remove this argument altogether

Done.

[lushnikov, 2016-07-20 01:44:38]

lgtm

It's verify this working on the macbook.

[luoe, 2016-07-20 17:15:50]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 17:16:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 18:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 18:38:31]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-07-22 03:01:01]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-07-22 03:02:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 04:43:24]

Description was changed from

==========
DevTools: remove isTrusted check and isUserGesture from ViewportControl

Previously, the ViewportControl never stuck to the bottom after a scroll event.
The event.isTrusted check was always true, so it was not correctly
distinguishing user-generated scroll events from script-generated ones.  This
CL removes isUserGesture accordingly.

BUG=613879
==========

to

==========
DevTools: remove isTrusted check and isUserGesture from ViewportControl

Previously, the ViewportControl never stuck to the bottom after a scroll event.
The event.isTrusted check was always true, so it was not correctly
distinguishing user-generated scroll events from script-generated ones.  This
CL removes isUserGesture accordingly.

BUG=613879
==========

[commit-bot: I haz the power, 2016-07-22 04:43:25]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-22 04:45:15]

Description was changed from

==========
DevTools: remove isTrusted check and isUserGesture from ViewportControl

Previously, the ViewportControl never stuck to the bottom after a scroll event.
The event.isTrusted check was always true, so it was not correctly
distinguishing user-generated scroll events from script-generated ones.  This
CL removes isUserGesture accordingly.

BUG=613879
==========

to

==========
DevTools: remove isTrusted check and isUserGesture from ViewportControl

Previously, the ViewportControl never stuck to the bottom after a scroll event.
The event.isTrusted check was always true, so it was not correctly
distinguishing user-generated scroll events from script-generated ones.  This
CL removes isUserGesture accordingly.

BUG=613879

Committed: https://crrev.com/2dbbaccdef5a4b1f1348792a8b5be93e58507d33
Cr-Commit-Position: refs/heads/master@{#407062}
==========

[commit-bot: I haz the power, 2016-07-22 04:45:16]

Patchset 5 (id:??) landed as
https://crrev.com/2dbbaccdef5a4b1f1348792a8b5be93e58507d33
Cr-Commit-Position: refs/heads/master@{#407062}