Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentVideoViewEmbedder.java

Issue 2154883003: Make ContentVideoView progress view visible in WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Java continuation lines identation Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentVideoViewEmbedder.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewEmbedder.java b/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewEmbedder.java
index 198a5a2bb18ed9c744e5b1257fac6adbb8823a6a..fadbe5b5fc43ab2e65a33cbcaf026e33ad80d8f4 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewEmbedder.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewEmbedder.java
@@ -23,20 +23,21 @@ public interface ContentVideoViewEmbedder {
* Called when the {@link ContentVideoView}, which contains the fullscreen video,
* is ready to be shown. Must be implemented.
* @param view The view containing the fullscreen video that embedders must show.
+ * @param isVideoLoaded The flag telling whether video has already been loaded.
+ * When it is false, embedder might show the progress view.
*/
- public void enterFullscreenVideo(View view);
+ public void enterFullscreenVideo(View view, boolean isVideoLoaded);
/**
- * Called to exit fullscreen video. Embedders must stop showing the view given in
- * {@link #enterFullscreenVideo(View)}. Must be implemented.
+ * Tells the embedder to remove the progress view.
*/
- public void exitFullscreenVideo();
+ public void fullscreenVideoLoaded();
/**
- * Allows the embedder to replace the view indicating that the video is loading.
- * If null is returned, the default video loading view is used.
+ * Called to exit fullscreen video. Embedders must stop showing the view given in
+ * {@link #enterFullscreenVideo(View)}. Must be implemented.
*/
- public View getVideoLoadingProgressView();
+ public void exitFullscreenVideo();
/**
* Sets the system ui visibility after entering or exiting fullscreen.

Powered by Google App Engine
This is Rietveld 408576698