chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java - Issue 2154883003: Make ContentVideoView progress view visible in WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

Issue 2154883003: Make ContentVideoView progress view visible in WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Java continuation lines identation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/test/shell/assets/full_screen_video_test_not_preloaded.html ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

index 0e0e76f53f414b1c1518b710b7425c5da419dfaa..36e994ba55d21c691d82a324083181729aaf0a66 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

@@ -412,15 +412,13 @@ public class OverlayPanel extends OverlayPanelAnimation implements ActivityState

// passing an empty implementation.

return new ContentVideoViewEmbedder() {

@Override

- public void enterFullscreenVideo(View view) {}

+ public void enterFullscreenVideo(View view, boolean isVideoLoaded) {}

@Override

- public void exitFullscreenVideo() {}

+ public void fullscreenVideoLoaded() {}

@Override

- public View getVideoLoadingProgressView() {

- return null;

- }

+ public void exitFullscreenVideo() {}

@Override

public void setSystemUiVisibility(boolean enterFullscreen) {}