Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2128)

Unified Diff: blimp/engine/Dockerfile

Issue 2154873002: Update ADD handling in Dockerfiles and test bundle creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Lint clean up. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/Dockerfile
diff --git a/blimp/engine/Dockerfile b/blimp/engine/Dockerfile
index 12b4b61894afe2372d701bfe99e715201485fdd0..e4ed62cae600e1119c261891b5c5a4e33e9c8f12 100644
--- a/blimp/engine/Dockerfile
+++ b/blimp/engine/Dockerfile
@@ -4,8 +4,8 @@ RUN mkdir /engine
RUN useradd -ms /bin/bash blimp_user
-# The glob below expands to all files, but does not add directories
-# recursively.
+# The glob below expands to all files in the working directory and the
+# contents of any subdirectory there.
Wez 2016/07/16 00:26:36 *scratches head* How has the behaviour changed if
Jess 2016/07/16 01:10:32 The behavior didn't change. The comment does not c
ADD * /engine/
ADD gen/third_party/blimp_fonts /engine/fonts
RUN mv /engine/chrome_sandbox /engine/chrome-sandbox
« no previous file with comments | « blimp/BUILD.gn ('k') | blimp/engine/testing/Dockerfile » ('j') | blimp/tools/create-bundle.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698