Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2044)

Unified Diff: blimp/engine/testing/Dockerfile

Issue 2154873002: Update ADD handling in Dockerfiles and test bundle creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update create-bundle.py comments to reflect most recent behavior changes. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/Dockerfile ('k') | blimp/tools/create-bundle.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/testing/Dockerfile
diff --git a/blimp/engine/testing/Dockerfile b/blimp/engine/testing/Dockerfile
index 71c87fc8f93373d464d83d126631c2e39d2a78da..cdce8fcd4c52654388d280bcecc1d1e990e8da95 100644
--- a/blimp/engine/testing/Dockerfile
+++ b/blimp/engine/testing/Dockerfile
@@ -4,15 +4,15 @@
# Engine itself.
FROM base:latest
-RUN mkdir -p /out/test/
+RUN mkdir -p /blimp/
-# The glob below expands to all files, but does not add directories
-# recursively.
-# Test binaries assume src directory is 2 levels down. While this behavior can
-# be changed with flags, the directory structure is set up to minimize
-# potential problems with initial integration.
-ADD * /out/test/
+RUN useradd -ms /bin/bash blimp_user
-RUN chown -R blimp_user /out/test/
+# Put all the Blimp related files in /blimp so they are kept separate from
+# the OS files. Using '.' instead of '*' ensures directory structure is
+# maintained since ADD only copies the contents of directories.
+ADD . /blimp/
+
+RUN chown -R blimp_user /blimp
USER blimp_user
« no previous file with comments | « blimp/engine/Dockerfile ('k') | blimp/tools/create-bundle.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698