Chromium Code Reviews Chromium Code Reviews
Issue 2154873002:
Update ADD handling in Dockerfiles and test bundle creation (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 # This Dockerfile is used to build a filesystem environment containing | 1 # This Dockerfile is used to build a filesystem environment containing |
| 2 # binaries and required files for Blimp Engine test and tests for dependencies | 2 # binaries and required files for Blimp Engine test and tests for dependencies |
| 3 # of Blimp Engine. It is built on the same base image that is used to run the | 3 # of Blimp Engine. It is built on the same base image that is used to run the |
| 4 # Engine itself. | 4 # Engine itself. |
| 5 FROM base:latest | 5 FROM base:latest |
| 6 | 6 |
| 7 RUN mkdir -p /out/test/ | 7 RUN mkdir -p /blimp/ |
| 8 | 8 |
| 9 # The glob below expands to all files, but does not add directories | 9 RUN useradd -ms /bin/bash blimp_user |
| 10 # recursively. | |
| 11 # Test binaries assume src directory is 2 levels down. While this behavior can | |
| 12 # be changed with flags, the directory structure is set up to minimize | |
| 13 # potential problems with initial integration. | |
| 14 ADD * /out/test/ | |
| 15 | 10 |
| 16 RUN chown -R blimp_user /out/test/ | 11 # Put all the blimp related files in /blimp so they are kept separate from |
|
maniscalco
2016/07/19 21:52:36
nit: blimp -> Blimp for consistency with other com
Jess
2016/07/19 22:32:41
Done.
| |
| 12 # the OS files. Using '.' instead of '*' ensures directory structure is | |
| 13 # maintained since ADD only copies the contents of directories | |
|
maniscalco
2016/07/19 21:52:36
nit: Missing period at end of sentence.
Jess
2016/07/19 22:32:41
Done.
| |
| 14 ADD . /blimp/ | |
| 15 | |
| 16 RUN chown -R blimp_user /blimp | |
| 17 | 17 |
| 18 USER blimp_user | 18 USER blimp_user |
| OLD | NEW |
