blimp/engine/Dockerfile - Issue 2154873002: Update ADD handling in Dockerfiles and test bundle creation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/engine/Dockerfile

Issue 2154873002: Update ADD handling in Dockerfiles and test bundle creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clarifying new script behavior in comments and argument naming. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 FROM base:latest	1 FROM base:latest

2	2

3 RUN mkdir /engine	3 RUN mkdir /engine

4	4

5 RUN useradd -ms /bin/bash blimp_user	5 RUN useradd -ms /bin/bash blimp_user

6	6

7 # The glob below expands to all files, but does not add directories

8 # recursively.

9 ADD * /engine/	7 ADD * /engine/

10 ADD gen/third_party/blimp_fonts /engine/fonts	8 ADD gen/third_party/blimp_fonts /engine/fonts

11 RUN mv /engine/chrome_sandbox /engine/chrome-sandbox	9 RUN mv /engine/chrome_sandbox /engine/chrome-sandbox

12 RUN chown -R blimp_user /engine	10 RUN chown -R blimp_user /engine

13	11

14 USER blimp_user	12 USER blimp_user

15 WORKDIR "/engine"	13 WORKDIR "/engine"

16	14

17 ENTRYPOINT ["/engine/start_engine.sh"]	15 ENTRYPOINT ["/engine/start_engine.sh"]

OLD	NEW

« no previous file with comments | « blimp/BUILD.gn ('k') | blimp/engine/testing/Dockerfile » ('j') | blimp/engine/testing/Dockerfile » ('J')