Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2154863002: Added switch to disable generating cached_patches.dart file (Dartium only). (Closed)

Created:
4 years, 5 months ago by terry
Modified:
4 years, 5 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added switch to disable generating cached_patches.dart file (Dartium only). The switch --no-cached-patches to be used by Dart enlistment (non-Dartium) and need to re-gen the sdk/lib files using: ./go.sh --no-cached-patches R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/2b1816c8696fae3655cd4b3d9f29566247035a9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M tools/dom/scripts/dartdomgenerator.py View 2 chunks +11 lines, -7 lines 0 comments Download
M tools/dom/scripts/go.sh View 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
terry
4 years, 5 months ago (2016-07-15 19:40:30 UTC) #1
Alan Knight
lgtm
4 years, 5 months ago (2016-07-15 19:41:49 UTC) #2
terry
4 years, 5 months ago (2016-07-18 12:45:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b1816c8696fae3655cd4b3d9f29566247035a9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698