fpdfsdk/javascript/global.h - Issue 2154843002: Clean up singleton implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/global.h

Issue 2154843002: Clean up singleton implementation (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/global.h

diff --git a/fpdfsdk/javascript/global.h b/fpdfsdk/javascript/global.h

index eca9aa12d1a8fdbde971f9a7c6df75df32651cc2..6604d9bad8428a7eef0629d274fd368f3c7629b5 100644

--- a/fpdfsdk/javascript/global.h

+++ b/fpdfsdk/javascript/global.h

@@ -11,6 +11,7 @@

#include <vector>

#include "fpdfsdk/javascript/JS_Define.h"

+#include "fpdfsdk/javascript/JS_KeyValue.h"

class CJS_GlobalData;

class CJS_GlobalVariableArray;

@@ -20,7 +21,7 @@ struct JSGlobalData {

JSGlobalData();

~JSGlobalData();

- int nType; // 0:int 1:bool 2:string 3:obj

+ JS_GlobalDataType nType;

double dData;

bool bData;

CFX_ByteString sData;

@@ -53,7 +54,7 @@ class JSGlobalAlternate : public CJS_EmbedObj {

void CommitGlobalPersisitentVariables(IJS_Context* cc);

void DestroyGlobalPersisitentVariables();

FX_BOOL SetGlobalVariables(const CFX_ByteString& propname,

- int nType,

+ JS_GlobalDataType nType,

double dData,

bool bData,

const CFX_ByteString& sData,

« no previous file with comments | « fpdfsdk/javascript/JS_KeyValue.cpp ('k') | fpdfsdk/javascript/global.cpp » ('j') | no next file with comments »