core/fpdfapi/include/cpdf_modulemgr.h - Issue 2154843002: Clean up singleton implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/fpdfapi/include/cpdf_modulemgr.h

Issue 2154843002: Clean up singleton implementation (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « core/fpdfapi/cpdf_modulemgr.cpp ('k') | core/fxge/ge/fx_ge.cpp » ('j') | core/fxge/include/fx_ge.h » ('J')

OLD	NEW
1 // Copyright 2016 PDFium Authors. All rights reserved.	1 // Copyright 2016 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef CORE_FPDFAPI_INCLUDE_CPDF_MODULEMGR_H_	7 #ifndef CORE_FPDFAPI_INCLUDE_CPDF_MODULEMGR_H_

8 #define CORE_FPDFAPI_INCLUDE_CPDF_MODULEMGR_H_	8 #define CORE_FPDFAPI_INCLUDE_CPDF_MODULEMGR_H_

9	9

10 #include <memory>	10 #include <memory>

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 CCodec_JpegModule* GetJpegModule();	49 CCodec_JpegModule* GetJpegModule();

50 CCodec_JpxModule* GetJpxModule();	50 CCodec_JpxModule* GetJpxModule();

51 CCodec_Jbig2Module* GetJbig2Module();	51 CCodec_Jbig2Module* GetJbig2Module();

52 CCodec_IccModule* GetIccModule();	52 CCodec_IccModule* GetIccModule();

53 CCodec_FlateModule* GetFlateModule();	53 CCodec_FlateModule* GetFlateModule();

54	54

55 private:	55 private:

56 CPDF_ModuleMgr();	56 CPDF_ModuleMgr();

57 ~CPDF_ModuleMgr();	57 ~CPDF_ModuleMgr();

58	58

	59 static CPDF_ModuleMgr* m_pDefaultMgr;
	Lei Zhang 2016/07/16 01:23:03 Leave it as a global, for the same reason as CPDFX Leave it as a global, for the same reason as CPDFXFA_App. Wei Li 2016/07/18 19:07:07 Not sure which style to follow as both g_ and s_ w Show quoted text On 2016/07/16 01:23:03, Lei Zhang wrote: > Leave it as a global, for the same reason as CPDFXFA_App. Not sure which style to follow as both g_ and s_ were used. Let's go with s_ to be different from global variables. Lei Zhang 2016/07/18 19:35:00 Sorry if I was unclear. What I was trying to say i Show quoted text On 2016/07/18 19:07:07, Wei Li wrote: > On 2016/07/16 01:23:03, Lei Zhang wrote: > > Leave it as a global, for the same reason as CPDFXFA_App. > > Not sure which style to follow as both g_ and s_ were used. Let's go with s_ to > be different from global variables. Sorry if I was unclear. What I was trying to say is this pointer can be declared in the .cpp file as a global in an anonymous namespace. Doesn't need to be in the header.
	60

59 CCodec_ModuleMgr* m_pCodecModule;	61 CCodec_ModuleMgr* m_pCodecModule;

60 std::unique_ptr<CPDF_PageModule> m_pPageModule;	62 std::unique_ptr<CPDF_PageModule> m_pPageModule;

61 std::unique_ptr<CFX_Deletable> m_pUnsupportInfoAdapter;	63 std::unique_ptr<CFX_Deletable> m_pUnsupportInfoAdapter;

62 };	64 };

63	65

64 #endif // CORE_FPDFAPI_INCLUDE_CPDF_MODULEMGR_H_	66 #endif // CORE_FPDFAPI_INCLUDE_CPDF_MODULEMGR_H_

OLD	NEW