Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 2154833002: Ignore show messages from RemoteFrames when the WebContents is hidden. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_delegate.h
diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h
index a72360c42728ceeb3eabb72701806cbb68b1ea6b..117ea37440b2378b878c1d998c6c76d1834920e9 100644
--- a/content/browser/renderer_host/render_widget_host_delegate.h
+++ b/content/browser/renderer_host/render_widget_host_delegate.h
@@ -177,7 +177,7 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {
virtual void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host,
const std::vector<uint8_t>& proto) {}
- // Called when the visibility of the RenderFrameProxyHost in outter
+ // Called when the visibility of the RenderFrameProxyHost in outer
// WebContents changes. This method is only called on an inner WebContents and
// will eventually notify all the RenderWidgetHostViews belonging to that
// WebContents.
@@ -194,6 +194,12 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {
// Returns the TextInputManager tracking text input state.
virtual TextInputManager* GetTextInputManager();
+ // Returns true if this RenderWidgetHost should remain hidden. This is used by
+ // the RenderWidgetHost to ask the delegate if it can be shown in the event of
+ // something other than the WebContents attempting to enable visibility of
+ // this RenderWidgetHost.
+ virtual bool IsHidden();
+
protected:
virtual ~RenderWidgetHostDelegate() {}
};

Powered by Google App Engine
This is Rietveld 408576698