Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2154833002: Ignore show messages from RemoteFrames when the WebContents is hidden. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 1933 matching lines...) Expand 10 before | Expand all | Expand 10 after
1944 } 1944 }
1945 1945
1946 void WebContentsImpl::ForwardCompositorProto( 1946 void WebContentsImpl::ForwardCompositorProto(
1947 RenderWidgetHostImpl* render_widget_host, 1947 RenderWidgetHostImpl* render_widget_host,
1948 const std::vector<uint8_t>& proto) { 1948 const std::vector<uint8_t>& proto) {
1949 if (delegate_) 1949 if (delegate_)
1950 delegate_->ForwardCompositorProto(render_widget_host, proto); 1950 delegate_->ForwardCompositorProto(render_widget_host, proto);
1951 } 1951 }
1952 1952
1953 void WebContentsImpl::OnRenderFrameProxyVisibilityChanged(bool visible) { 1953 void WebContentsImpl::OnRenderFrameProxyVisibilityChanged(bool visible) {
1954 if (visible) 1954 if (visible && !GetOuterWebContents()->IsHidden())
1955 WasShown(); 1955 WasShown();
1956 else 1956 else if (!visible)
1957 WasHidden(); 1957 WasHidden();
1958 } 1958 }
1959 1959
1960 void WebContentsImpl::CreateNewWindow( 1960 void WebContentsImpl::CreateNewWindow(
1961 SiteInstance* source_site_instance, 1961 SiteInstance* source_site_instance,
1962 int32_t route_id, 1962 int32_t route_id,
1963 int32_t main_frame_route_id, 1963 int32_t main_frame_route_id,
1964 int32_t main_frame_widget_route_id, 1964 int32_t main_frame_widget_route_id,
1965 const ViewHostMsg_CreateWindow_Params& params, 1965 const ViewHostMsg_CreateWindow_Params& params,
1966 SessionStorageNamespace* session_storage_namespace) { 1966 SessionStorageNamespace* session_storage_namespace) {
(...skipping 3203 matching lines...) Expand 10 before | Expand all | Expand 10 after
5170 for (RenderViewHost* render_view_host : render_view_host_set) 5170 for (RenderViewHost* render_view_host : render_view_host_set)
5171 render_view_host->OnWebkitPreferencesChanged(); 5171 render_view_host->OnWebkitPreferencesChanged();
5172 } 5172 }
5173 5173
5174 void WebContentsImpl::SetJavaScriptDialogManagerForTesting( 5174 void WebContentsImpl::SetJavaScriptDialogManagerForTesting(
5175 JavaScriptDialogManager* dialog_manager) { 5175 JavaScriptDialogManager* dialog_manager) {
5176 dialog_manager_ = dialog_manager; 5176 dialog_manager_ = dialog_manager;
5177 } 5177 }
5178 5178
5179 } // namespace content 5179 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698