Ignore show messages from RemoteFrames when the WebContents is hidden.

content/browser/frame_host/cross_process_frame_connector.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/cross_process_frame_connector.h"
 
 #include "cc/surfaces/surface.h"
 #include "cc/surfaces/surface_manager.h"
 #include "content/browser/compositor/surface_utils.h"
 #include "content/browser/frame_host/frame_tree.h"
@@ skipping 254 matching lines @@
 
   // If there is an inner WebContents, it should be notified of the change in
   // the visibility. The Show/Hide methods will not be called if an inner
   // WebContents exists since the corresponding WebContents will itself call
   // Show/Hide on all the RenderWidgetHostViews (including this) one.
   if (frame_proxy_in_parent_renderer_->frame_tree_node()
           ->render_manager()
           ->ForInnerDelegate()) {
     RenderWidgetHostImpl::From(view_->GetRenderWidgetHost())
         ->delegate()
         ->OnRenderFrameProxyVisibilityChanged(visible);

[kenrb, 2016/07/18 17:11:45]

Why is the check done in the WebContents rather than here?

[lfg, 2016/07/18 17:44:00]

No particular reason, I just thought the check in WebContents is simpler. Why do
you think it should be here?

Since we are crossing WebContents boundaries here, we would have to check the
delegate of the parent view instead of the delegate of the view which could be
more confusing than doing the check in the WebContents.

[kenrb, 2016/07/18 18:05:28]

Okay, that's fine. The only advantage of having it here would be to have the
check in the same place for all RWHVCFs.

     return;
   }
 
-  if (visible)
+  if (visible &&
+      !RenderWidgetHostImpl::From(view_->GetRenderWidgetHost())
+           ->delegate()
+           ->IsHidden()) {
     view_->Show();
-  else
+  } else if (!visible) {
     view_->Hide();
+  }
 }
 
 void CrossProcessFrameConnector::SetDeviceScaleFactor(float scale_factor) {
   device_scale_factor_ = scale_factor;
   // The RenderWidgetHost is null in unit tests.
   if (view_ && view_->GetRenderWidgetHost()) {
     RenderWidgetHostImpl* child_widget =
         RenderWidgetHostImpl::From(view_->GetRenderWidgetHost());
     child_widget->NotifyScreenInfoChanged();
   }
@@ skipping 53 matching lines @@
 
   if (parent) {
     return static_cast<RenderWidgetHostViewBase*>(
         parent->current_frame_host()->GetView());
   }
 
   return nullptr;
 }
 
 }  // namespace content