components/component_updater/default_component_installer_unittest.cc - Issue 2154773002: Implement Just-In-Time Flash updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/default_component_installer_unittest.cc

Issue 2154773002: Implement Just-In-Time Flash updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First Review Pass Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/component_updater/component_updater_service_internal.h ('K') | « components/component_updater/default_component_installer.cc ('k') | components/component_updater/mock_component_updater_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/default_component_installer_unittest.cc

diff --git a/components/component_updater/default_component_installer_unittest.cc b/components/component_updater/default_component_installer_unittest.cc

index 184ef2b84455eba509590f225c87a849178a5096..8b519f9757bb0058f84a0b62326adf12ff20f083 100644

--- a/components/component_updater/default_component_installer_unittest.cc

+++ b/components/component_updater/default_component_installer_unittest.cc

@@ -102,6 +102,9 @@ class FakeInstallerTraits : public ComponentInstallerTraits {

return installer_attributes;

}

+ void AddMimeTypes(std::vector<std::string>* mime_types) const override {}

Bernhard Bauer 2016/07/28 10:25:10 Nit: remove one empty line.

waffles 2016/07/28 20:06:27 Done.

private:

static void GetPkHash(std::vector<uint8_t>* hash) {

hash->assign(std::begin(kSha256Hash), std::end(kSha256Hash));