src/effects/SkXfermodeImageFilter.cpp - Issue 2154753003: Introduce GrColorSpaceXform, for gamut conversion on textures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkXfermodeImageFilter.cpp

Issue 2154753003: Introduce GrColorSpaceXform, for gamut conversion on textures (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: More progress & refactoring Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkXfermodeImageFilter.cpp

diff --git a/src/effects/SkXfermodeImageFilter.cpp b/src/effects/SkXfermodeImageFilter.cpp

index 785b46fcc70d321821aeea7abbeaea505783243c..345e6e504a9a00c523ca672b2ff4ba2e4978dfd6 100644

--- a/src/effects/SkXfermodeImageFilter.cpp

+++ b/src/effects/SkXfermodeImageFilter.cpp

@@ -188,7 +188,7 @@ sk_sp<SkSpecialImage> SkXfermodeImageFilter::filterImageGPU(SkSpecialImage* sour

backgroundMatrix.preTranslate(SkIntToScalar(-backgroundOffset.fX),

SkIntToScalar(-backgroundOffset.fY));

bgFP = GrTextureDomainEffect::Make(

- backgroundTex.get(), backgroundMatrix,

+ backgroundTex.get(), nullptr, backgroundMatrix,

GrTextureDomain::MakeTexelDomain(backgroundTex.get(),

background->subset()),

GrTextureDomain::kDecal_Mode,

@@ -207,7 +207,7 @@ sk_sp<SkSpecialImage> SkXfermodeImageFilter::filterImageGPU(SkSpecialImage* sour

sk_sp<GrFragmentProcessor> foregroundFP;

foregroundFP = GrTextureDomainEffect::Make(

- foregroundTex.get(), foregroundMatrix,

+ foregroundTex.get(), nullptr, foregroundMatrix,

GrTextureDomain::MakeTexelDomain(foregroundTex.get(),

foreground->subset()),

GrTextureDomain::kDecal_Mode,

« no previous file with comments | « src/effects/SkMagnifierImageFilter.cpp ('k') | src/gpu/GrBlurUtils.cpp » ('j') | no next file with comments »