src/gpu/effects/GrMatrixConvolutionEffect.cpp - Issue 2154753003: Introduce GrColorSpaceXform, for gamut conversion on textures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrMatrixConvolutionEffect.cpp

Issue 2154753003: Introduce GrColorSpaceXform, for gamut conversion on textures (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Only plumb to effect - no need to store xform on GrTextureAccess Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrMatrixConvolutionEffect.cpp

diff --git a/src/gpu/effects/GrMatrixConvolutionEffect.cpp b/src/gpu/effects/GrMatrixConvolutionEffect.cpp

index 5422755c2e8f8e42176e8a1dea01f737d33f6835..8f031904caa14c2643165d41559274eb710e3bba 100644

--- a/src/gpu/effects/GrMatrixConvolutionEffect.cpp

+++ b/src/gpu/effects/GrMatrixConvolutionEffect.cpp

@@ -155,7 +155,7 @@ GrMatrixConvolutionEffect::GrMatrixConvolutionEffect(GrTexture* texture,

const SkIPoint& kernelOffset,

GrTextureDomain::Mode tileMode,

bool convolveAlpha)

- : INHERITED(texture, GrCoordTransform::MakeDivByTextureWHMatrix(texture)),

+ : INHERITED(texture, nullptr, GrCoordTransform::MakeDivByTextureWHMatrix(texture)),

fKernelSize(kernelSize),

fGain(SkScalarToFloat(gain)),

fBias(SkScalarToFloat(bias) / 255.0f),