tests/SRGBMipMapTest.cpp - Issue 2154753003: Introduce GrColorSpaceXform, for gamut conversion on textures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/SRGBMipMapTest.cpp

Issue 2154753003: Introduce GrColorSpaceXform, for gamut conversion on textures (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/SRGBMipMapTest.cpp

diff --git a/tests/SRGBMipMapTest.cpp b/tests/SRGBMipMapTest.cpp

index f9ee037e7bd744a1f21ab85866f6f8c016afafea..5001a9e094ba1b6d05743427b7827b158a8663c8 100644

--- a/tests/SRGBMipMapTest.cpp

+++ b/tests/SRGBMipMapTest.cpp

@@ -146,7 +146,7 @@ DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SRGBMipMaps, reporter, ctxInfo) {

GrPaint paint;

paint.setPorterDuffXPFactory(SkXfermode::kSrc_Mode);

GrTextureParams mipMapParams(SkShader::kRepeat_TileMode, GrTextureParams::kMipMap_FilterMode);

- paint.addColorTextureProcessor(texture, SkMatrix::MakeScale(0.5f), mipMapParams);

+ paint.addColorTextureProcessor(texture, nullptr, SkMatrix::MakeScale(0.5f), mipMapParams);

// 1) Draw texture to S32 surface (should generate/use sRGB mips)

paint.setGammaCorrect(true);