Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2154733003: Remove SkDOM::build(const char doc[], size_t len) (Closed)

Created:
4 years, 5 months ago by f(malita)
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkDOM::build(const char doc[], size_t len) This flavor is unused, and we have the more general SkStream API. R=stephana@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2154733003 Committed: https://skia.googlesource.com/skia/+/a427cc4d6b025b38b5bacd97f98325f9770e1769

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M include/xml/SkDOM.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/xml/SkDOM.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/SkDOMTest.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
f(malita)
4 years, 5 months ago (2016-07-15 15:34:50 UTC) #2
robertphillips
lgtm
4 years, 5 months ago (2016-07-15 15:40:05 UTC) #7
stephana
On 2016/07/15 15:40:05, robertphillips wrote: > lgtm lgtm
4 years, 5 months ago (2016-07-15 16:58:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154733003/20001
4 years, 5 months ago (2016-07-15 18:02:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/11319)
4 years, 5 months ago (2016-07-15 18:03:42 UTC) #15
f(malita)
Needs API blessing from Mike.
4 years, 5 months ago (2016-07-18 17:16:18 UTC) #16
reed1
lgtm
4 years, 5 months ago (2016-07-18 17:34:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154733003/20001
4 years, 5 months ago (2016-07-18 17:35:27 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 17:56:48 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a427cc4d6b025b38b5bacd97f98325f9770e1769

Powered by Google App Engine
This is Rietveld 408576698