Issue 215473002: Remove WebFrame::findChildByExpression.

Issue 215473002: Remove WebFrame::findChildByExpression. (Closed)

Created:
6 years, 9 months ago by Avi (use Gerrit)

Modified:
6 years, 8 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Remove WebFrame::findChildByExpression. This was used to find frames by xpath, but it has no remaining callers. BUG=304341 TEST=no change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170609

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -26 lines)			Patch
M	Source/web/WebFrameImpl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebFrameImpl.cpp	View	1	2 chunks	+0 lines, -20 lines	0 comments	Download
M	Source/web/tests/WebFrameTest.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	public/web/WebFrame.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 7 (0 generated)

Avi (use Gerrit)

This will have no callers once https://codereview.chromium.org/208793005/ lands next week, but I wanted to have ...

6 years, 9 months ago (2014-03-27 21:03:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/215473002/20001

6 years, 8 months ago (2014-04-01 19:33:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/215473002/20001

6 years, 8 months ago (2014-04-01 22:03:29 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/215473002/20001

6 years, 8 months ago (2014-04-01 22:41:44 UTC) #6

Message was sent while issue was closed.

Change committed as 170609