Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2154723002: Revert of Convert SIMD wasm ops to runtime function calls (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Convert SIMD wasm ops to runtime function calls (patchset #17 id:320001 of https://codereview.chromium.org/1991143002/ ) Reason for revert: [Sheriff] Violates msan and tsan: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/9663 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10670 Original issue's description: > Convert SIMD machine ops to runtime function calls > - Add Simd128 type to Wasm AST types > - Add a pass that converts SIMD machine ops to runtime calls > - Sample opcodes Int32x4Splat, Int32x4ExtractLane and test > - Separate out generic SIMD Machine ops as these cannot be > handled by runtime functions just yet. > > LOG=N > BUG=v8:4124 > > R=bradnelson@chromium.org, bbudge@chromium.org, titzer@chromium.org > > Committed: https://crrev.com/73df92fc2fdbbfadc17e8ab4e58ec56ae2b3d91a > Cr-Commit-Position: refs/heads/master@{#37789} TBR=bbudge@chromium.org,bradnelson@chromium.org,titzer@chromium.org,gdeepti@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Committed: https://crrev.com/9f46c1112b98e0e3e6317d244a76b96516b1ef16 Cr-Commit-Position: refs/heads/master@{#37790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -465 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D src/compiler/simd-lowering.h View 1 chunk +0 lines, -38 lines 0 comments Download
D src/compiler/simd-lowering.cc View 1 chunk +0 lines, -136 lines 0 comments Download
M src/compiler/wasm-compiler.h View 8 chunks +0 lines, -15 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 6 chunks +0 lines, -120 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/wasm/ast-decoder.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/wasm/wasm-opcodes.cc View 2 chunks +3 lines, -23 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -2 lines 0 comments Download
D test/cctest/wasm/test-run-wasm-simd.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M test/cctest/wasm/test-signatures.h View 5 chunks +1 line, -7 lines 0 comments Download
D test/mjsunit/wasm/test-wasm-simd-ops.js View 1 chunk +0 lines, -23 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Convert SIMD wasm ops to runtime function calls
4 years, 5 months ago (2016-07-15 08:59:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154723002/1
4 years, 5 months ago (2016-07-15 08:59:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 08:59:49 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 09:00:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f46c1112b98e0e3e6317d244a76b96516b1ef16
Cr-Commit-Position: refs/heads/master@{#37790}

Powered by Google App Engine
This is Rietveld 408576698