Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2154713003:
Skip the pointer event tests which failed on WebKit Linux Leak (Closed)
DescriptionSkip the pointer event tests which failed on WebKit Linux Leak.
The below pointer event tests cause memory leak.
pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
BUG=628660
Committed: https://crrev.com/906c4dd5e78d5979d270011841e630cf017057ec
Cr-Commit-Position: refs/heads/master@{#405931}
Patch Set 1 : skip tests #
Total comments: 1
Patch Set 2 : Regroup them #
Total comments: 1
Messages
Total messages: 24 (15 generated)
Description was changed from ========== skip tests BUG=628660 ========== to ========== Skip the pointer event tests which failed on WebKit Linux Leak. The below pointer event tests cause memory leak. pointerevents/pointerevent_touch-action-auto-css_touch-manual.html pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html BUG=628660 ==========
lanwei@chromium.org changed reviewers: + rbyers@chromium.org
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM with nit https://codereview.chromium.org/2154713003/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2154713003/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/TestExpectations:923: crbug.com/619060 imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html [ Skip ] nit: since these are due to the linux leak detector, should they move to the section above and have [ Linux ] like other leak-detector-specific issues?
lanwei@chromium.org changed reviewers: + nzolghadr@chromium.org
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by lanwei@chromium.org
The CQ bit was checked by lanwei@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org Link to the patchset: https://codereview.chromium.org/2154713003/#ps40001 (title: "Regroup them")
lgtm https://codereview.chromium.org/2154713003/diff/40001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2154713003/diff/40001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/TestExpectations:902: crbug.com/619060 [ Linux ] imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html [ Skip ] This is very good that presubmit check at least doesn't give any error having different rules for the same file.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lanwei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Skip the pointer event tests which failed on WebKit Linux Leak. The below pointer event tests cause memory leak. pointerevents/pointerevent_touch-action-auto-css_touch-manual.html pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html BUG=628660 ========== to ========== Skip the pointer event tests which failed on WebKit Linux Leak. The below pointer event tests cause memory leak. pointerevents/pointerevent_touch-action-auto-css_touch-manual.html pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html BUG=628660 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Skip the pointer event tests which failed on WebKit Linux Leak. The below pointer event tests cause memory leak. pointerevents/pointerevent_touch-action-auto-css_touch-manual.html pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html BUG=628660 ========== to ========== Skip the pointer event tests which failed on WebKit Linux Leak. The below pointer event tests cause memory leak. pointerevents/pointerevent_touch-action-auto-css_touch-manual.html pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html BUG=628660 Committed: https://crrev.com/906c4dd5e78d5979d270011841e630cf017057ec Cr-Commit-Position: refs/heads/master@{#405931} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/906c4dd5e78d5979d270011841e630cf017057ec Cr-Commit-Position: refs/heads/master@{#405931} |
