Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2154673002: Remove comment about blink::ResourceResponse subclass (Closed)

Created:
4 years, 5 months ago by Adam Rice
Modified:
4 years, 5 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove comment about blink::ResourceResponse subclass class blink::ResourceResponse is final and so can have no subclasses. Remove a comment mentioning subclasses. BUG= Committed: https://crrev.com/3c973182a5fe42ed6736927f8fb57a3fca726406 Cr-Commit-Position: refs/heads/master@{#405738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/platform/network/ResourceResponse.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Adam Rice
+kinuko. Trivial comment fix. PTAL.
4 years, 5 months ago (2016-07-15 06:46:53 UTC) #4
kinuko
lgtm
4 years, 5 months ago (2016-07-15 06:47:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154673002/1
4 years, 5 months ago (2016-07-15 09:18:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 10:24:57 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 10:26:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c973182a5fe42ed6736927f8fb57a3fca726406
Cr-Commit-Position: refs/heads/master@{#405738}

Powered by Google App Engine
This is Rietveld 408576698