Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2154623002: [DevTools] Make most fields of ExceptionDetails non-optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 */ 364 */
365 exceptionThrown: function(exceptionId, timestamp, details, exception, execut ionContextId) 365 exceptionThrown: function(exceptionId, timestamp, details, exception, execut ionContextId)
366 { 366 {
367 var consoleMessage = new WebInspector.ConsoleMessage( 367 var consoleMessage = new WebInspector.ConsoleMessage(
368 this._runtimeModel.target(), 368 this._runtimeModel.target(),
369 WebInspector.ConsoleMessage.MessageSource.JS, 369 WebInspector.ConsoleMessage.MessageSource.JS,
370 WebInspector.ConsoleMessage.MessageLevel.Error, 370 WebInspector.ConsoleMessage.MessageLevel.Error,
371 details.text, 371 details.text,
372 undefined, 372 undefined,
373 details.url, 373 details.url,
374 typeof details.lineNumber === "undefined" ? undefined : details.line Number + 1, 374 details.lineNumber + 1,
375 typeof details.columnNumber === "undefined" ? undefined : details.co lumnNumber + 1, 375 details.columnNumber + 1,
376 undefined, 376 undefined,
377 exception ? ["Uncaught (in promise)", exception] : undefined, 377 exception ? ["Uncaught (in promise)", exception] : undefined,
378 details.stack, 378 details.stackTrace,
379 timestamp, 379 timestamp,
380 executionContextId, 380 executionContextId,
381 details.scriptId); 381 details.scriptId);
382 consoleMessage.setExceptionId(exceptionId); 382 consoleMessage.setExceptionId(exceptionId);
383 this._runtimeModel.target().consoleModel.addMessage(consoleMessage); 383 this._runtimeModel.target().consoleModel.addMessage(consoleMessage);
384 }, 384 },
385 385
386 /** 386 /**
387 * @override 387 * @override
388 * @param {number} timestamp 388 * @param {number} timestamp
(...skipping 576 matching lines...) Expand 10 before | Expand all | Expand 10 after
965 /** 965 /**
966 * @return {boolean} 966 * @return {boolean}
967 */ 967 */
968 isNormalListenerType: function() 968 isNormalListenerType: function()
969 { 969 {
970 return this._listenerType === "normal"; 970 return this._listenerType === "normal";
971 }, 971 },
972 972
973 __proto__: WebInspector.SDKObject.prototype 973 __proto__: WebInspector.SDKObject.prototype
974 } 974 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698