Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2154603003: [HBD] Don't advertise flash if PreferHtmlOverPlugins feature is enabled (Closed)

Created:
4 years, 5 months ago by trizzofo
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, tommycli
CC:
chromium-reviews, jam, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PreferHtmlOverPlugins feature and don't advertise Flash when it's enabled. BUG=626728 Committed: https://crrev.com/4af0c1a2a170613c0b5ad5460fce240d1d34d872 Cr-Commit-Position: refs/heads/master@{#405911}

Patch Set 1 #

Patch Set 2 : Format #

Total comments: 2

Patch Set 3 : Change constant used #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/plugins/chrome_plugin_service_filter.cc View 1 2 4 chunks +8 lines, -1 line 0 comments Download
M chrome/common/chrome_features.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
trizzofo
4 years, 5 months ago (2016-07-15 23:17:42 UTC) #4
tommycli
https://codereview.chromium.org/2154603003/diff/20001/chrome/browser/plugins/chrome_plugin_service_filter.cc File chrome/browser/plugins/chrome_plugin_service_filter.cc (right): https://codereview.chromium.org/2154603003/diff/20001/chrome/browser/plugins/chrome_plugin_service_filter.cc#newcode111 chrome/browser/plugins/chrome_plugin_service_filter.cc:111: if (plugin->path.BaseName() == flashPath && plugin.name == base::ASCIIToUTF16(content::kFlashPluginName) ? ...
4 years, 5 months ago (2016-07-15 23:22:22 UTC) #6
trizzofo
https://codereview.chromium.org/2154603003/diff/20001/chrome/browser/plugins/chrome_plugin_service_filter.cc File chrome/browser/plugins/chrome_plugin_service_filter.cc (right): https://codereview.chromium.org/2154603003/diff/20001/chrome/browser/plugins/chrome_plugin_service_filter.cc#newcode111 chrome/browser/plugins/chrome_plugin_service_filter.cc:111: if (plugin->path.BaseName() == flashPath && On 2016/07/15 23:22:22, tommycli ...
4 years, 5 months ago (2016-07-15 23:34:29 UTC) #7
tommycli
LGTM. you will still need a chrome/ reviewer. thanks
4 years, 5 months ago (2016-07-15 23:46:28 UTC) #8
trizzofo
Lei Zhang, PTAL
4 years, 5 months ago (2016-07-16 00:10:02 UTC) #12
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-16 00:21:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154603003/40001
4 years, 5 months ago (2016-07-16 00:29:20 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-16 00:34:05 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-16 00:34:09 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 00:35:26 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4af0c1a2a170613c0b5ad5460fce240d1d34d872
Cr-Commit-Position: refs/heads/master@{#405911}

Powered by Google App Engine
This is Rietveld 408576698