third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2154593003: [css-grid] Fix indefinite height detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2154593003: [css-grid] Fix indefinite height detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: New version Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index 5390b7360ae1ca2e7fe1d29e0e78682f75fafc1b..328bbc60d72e50a60348d53298edb6a1f17ffd67 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -557,6 +557,7 @@ LayoutBlock* LayoutBoxModelObject::containingBlockForAutoHeightDetection(Length

bool LayoutBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight(bool checkingContainingBlock) const

{

+ // TODO(rego): Check if we can somehow reuse LayoutBlock::availableLogicalHeightForPercentageComputation().

const LayoutBox* thisBox = isBox() ? toLayoutBox(this) : nullptr;

Length logicalHeightLength = style()->logicalHeight();

LayoutBlock* cb = containingBlockForAutoHeightDetection(logicalHeightLength);