third_party/WebKit/Source/core/layout/LayoutBlock.h - Issue 2154593003: [css-grid] Fix indefinite height detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 2154593003: [css-grid] Fix indefinite height detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check skipContainingBlockForPercentHeightCalculation() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h

index 1838d904c6a8afe17f12738b85ad50ed800e7c07..97075b36f471ea1378c5215d37fd8755b1c3dcc4 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h

@@ -226,6 +226,9 @@ public:

void checkPositionedObjectsNeedLayout();

#endif

+ LayoutUnit availableLogicalHeightForPercentageComputation() const;

+ bool hasDefiniteLogicalHeight() const;

protected:

bool recalcNormalFlowChildOverflowIfNeeded(LayoutObject*);

bool recalcPositionedDescendantsOverflowAfterStyleChange();