[css-grid] Fix indefinite height detection

third_party/WebKit/Source/core/layout/LayoutBlock.h

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h
index 1838d904c6a8afe17f12738b85ad50ed800e7c07..97075b36f471ea1378c5215d37fd8755b1c3dcc4 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h
@@ -226,6 +226,9 @@ public:
     void checkPositionedObjectsNeedLayout();
 #endif
 
+    LayoutUnit availableLogicalHeightForPercentageComputation() const;

[cbiesinger, 2016/08/25 21:50:23]

Upon re-reading this patch, I really think this needs a comment that you need to
call this function on the right containing block --
computePercentageLogicalHeight has the function to find the containing block,
but you did not move it to the new function.

[Manuel Rego, 2016/08/29 11:08:54]

We want to be able to call this function directly on any block,
that's why it doesn't have the loop to find the right containing block.
It's true that we've an issue now that we can call this from anywhere
(due to hasDefiniteLogicalHeight()).

I've added a check using skipContainingBlockForPercentHeightCalculation(),
it seems that if this is true we can consider that the element has an indefinite
height.
Basically they're mostly anonymous blocks that are skipped
during percentage height calculations, so I guess it's fine to consider
they have an indefinite height for the purpose of hasDefiniteLogicalHeight().

+    bool hasDefiniteLogicalHeight() const;

[cbiesinger, 2016/08/25 21:50:22]

..and that previous point makes me think this function might not be correct?

+
 protected:
     bool recalcNormalFlowChildOverflowIfNeeded(LayoutObject*);
     bool recalcPositionedDescendantsOverflowAfterStyleChange();