[css-grid] Fix indefinite height detection

third_party/WebKit/Source/core/layout/LayoutBlock.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 208 matching lines @@
     LayoutUnit startOffsetForContent() const { return style()->isLeftToRightDirection() ? logicalLeftOffsetForContent() : logicalWidth() - logicalRightOffsetForContent(); }
     LayoutUnit endOffsetForContent() const { return !style()->isLeftToRightDirection() ? logicalLeftOffsetForContent() : logicalWidth() - logicalRightOffsetForContent(); }
 
     virtual LayoutUnit logicalLeftSelectionOffset(const LayoutBlock* rootBlock, LayoutUnit position) const;
     virtual LayoutUnit logicalRightSelectionOffset(const LayoutBlock* rootBlock, LayoutUnit position) const;
 
 #if ENABLE(ASSERT)
     void checkPositionedObjectsNeedLayout();
 #endif
 
+    static LayoutUnit availableLogicalHeightForPercentageComputation(const LayoutBlock&);

[cbiesinger, 2016/07/21 20:57:28]

Why make this a static function and pass in a block, when you could just make
this a member function on that block?

[Manuel Rego, 2016/07/22 13:05:37]

Yeah good idea it can be a member const function,
like hasDefiniteLogicalHeight().

+    bool hasDefiniteLogicalHeight() const;
+
 protected:
     bool recalcNormalFlowChildOverflowIfNeeded(LayoutObject*);
     bool recalcPositionedDescendantsOverflowAfterStyleChange();
 public:
     virtual bool recalcChildOverflowAfterStyleChange();
     bool recalcOverflowAfterStyleChange();
 
     // An example explaining layout tree structure about first-line style:
     // <style>
     //   #enclosingFirstLineStyleBlock::first-line { ... }
@@ skipping 175 matching lines @@
     // FIXME: This is temporary as we move code that accesses block flow
     // member variables out of LayoutBlock and into LayoutBlockFlow.
     friend class LayoutBlockFlow;
 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
 
 } // namespace blink
 
 #endif // LayoutBlock_h