Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 2154593002: [Android] Define the Android NDK major version for breakpad. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
Reviewers:
Mark Mentovai, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Define the Android NDK major version for breakpad. common/android/include/sys/user.h includes some workarounds for specific NDK versions. Some of those workarounds need to be changed in order to upgrade the NDK. Defining the NDK major version here will allow breakpad to use preprocessor guards around the version-specific workarounds, easing the transition. BUG=599327 Committed: https://crrev.com/544124e0ffb4718bd37dfb36be288121b47c11ec Cr-Commit-Position: refs/heads/master@{#405761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M breakpad/BUILD.gn View 5 chunks +10 lines, -12 lines 0 comments Download
M build/config/android/config.gni View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
ptal: mark: breakpad/ agrieve: build/
4 years, 5 months ago (2016-07-15 01:53:31 UTC) #2
agrieve
On 2016/07/15 01:53:31, jbudorick wrote: > ptal: > > mark: breakpad/ > agrieve: build/ lgtm
4 years, 5 months ago (2016-07-15 14:06:02 UTC) #3
Mark Mentovai
LGTM
4 years, 5 months ago (2016-07-15 14:20:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154593002/1
4 years, 5 months ago (2016-07-15 14:23:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 15:49:38 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 15:52:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/544124e0ffb4718bd37dfb36be288121b47c11ec
Cr-Commit-Position: refs/heads/master@{#405761}

Powered by Google App Engine
This is Rietveld 408576698