Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2154583002: dart2js: get:hashCode methods to avoid Object.hashCode (Closed)

Created:
4 years, 5 months ago by sra1
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: get:hashCode methods to avoid Object.hashCode R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/7749b715d4cb1d8673c112e6b3dc454c3e6aa2d6

Patch Set 1 #

Patch Set 2 : xxx #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -23 lines) Patch
M pkg/compiler/lib/src/closure.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/common/tasks.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 3 chunks +8 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
4 years, 5 months ago (2016-07-15 01:42:45 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-07-15 19:55:22 UTC) #3
sra1
4 years, 5 months ago (2016-07-15 20:32:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7749b715d4cb1d8673c112e6b3dc454c3e6aa2d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698