Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: ash/shell.cc

Issue 2154523002: Move AccessibilityDelegate ownership to ash::WmShell (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@setmediadelegate
Patch Set: cleanup, fix test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shell.h" 5 #include "ash/shell.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
11 #include "ash/accelerators/accelerator_controller.h" 11 #include "ash/accelerators/accelerator_controller.h"
12 #include "ash/accelerators/accelerator_delegate.h" 12 #include "ash/accelerators/accelerator_delegate.h"
13 #include "ash/accelerators/focus_manager_factory.h" 13 #include "ash/accelerators/focus_manager_factory.h"
14 #include "ash/aura/wm_shell_aura.h" 14 #include "ash/aura/wm_shell_aura.h"
15 #include "ash/aura/wm_window_aura.h" 15 #include "ash/aura/wm_window_aura.h"
16 #include "ash/autoclick/autoclick_controller.h" 16 #include "ash/autoclick/autoclick_controller.h"
17 #include "ash/common/accessibility_delegate.h"
18 #include "ash/common/ash_switches.h" 17 #include "ash/common/ash_switches.h"
19 #include "ash/common/gpu_support.h" 18 #include "ash/common/gpu_support.h"
20 #include "ash/common/keyboard/keyboard_ui.h" 19 #include "ash/common/keyboard/keyboard_ui.h"
21 #include "ash/common/login_status.h" 20 #include "ash/common/login_status.h"
22 #include "ash/common/pointer_watcher_delegate.h" 21 #include "ash/common/pointer_watcher_delegate.h"
23 #include "ash/common/session/session_state_delegate.h" 22 #include "ash/common/session/session_state_delegate.h"
24 #include "ash/common/shelf/shelf_item_delegate.h" 23 #include "ash/common/shelf/shelf_item_delegate.h"
25 #include "ash/common/shelf/shelf_item_delegate_manager.h" 24 #include "ash/common/shelf/shelf_item_delegate_manager.h"
26 #include "ash/common/shelf/shelf_model.h" 25 #include "ash/common/shelf/shelf_model.h"
27 #include "ash/common/shell_delegate.h" 26 #include "ash/common/shell_delegate.h"
(...skipping 733 matching lines...) Expand 10 before | Expand all | Expand 10 after
761 audio_a11y_controller_.reset(); 760 audio_a11y_controller_.reset();
762 #endif // defined(OS_CHROMEOS) 761 #endif // defined(OS_CHROMEOS)
763 762
764 // This also deletes all RootWindows. Note that we invoke Shutdown() on 763 // This also deletes all RootWindows. Note that we invoke Shutdown() on
765 // WindowTreeHostManager before resetting |window_tree_host_manager_|, since 764 // WindowTreeHostManager before resetting |window_tree_host_manager_|, since
766 // destruction 765 // destruction
767 // of its owned RootWindowControllers relies on the value. 766 // of its owned RootWindowControllers relies on the value.
768 display_manager_->CreateScreenForShutdown(); 767 display_manager_->CreateScreenForShutdown();
769 display_configuration_controller_.reset(); 768 display_configuration_controller_.reset();
770 769
771 wm_shell_->PrepareForShutdown(); 770 wm_shell_->Shutdown();
772 // Depends on |focus_client_|, so must be destroyed before. 771 // Depends on |focus_client_|, so must be destroyed before.
773 window_tree_host_manager_->Shutdown(); 772 window_tree_host_manager_->Shutdown();
774 window_tree_host_manager_.reset(); 773 window_tree_host_manager_.reset();
775 focus_client_.reset(); 774 focus_client_.reset();
776 screen_position_controller_.reset(); 775 screen_position_controller_.reset();
777 accessibility_delegate_.reset();
778 new_window_delegate_.reset(); 776 new_window_delegate_.reset();
779 pointer_watcher_delegate_.reset(); 777 pointer_watcher_delegate_.reset();
780 778
781 keyboard::KeyboardController::ResetInstance(nullptr); 779 keyboard::KeyboardController::ResetInstance(nullptr);
782 780
783 #if defined(OS_CHROMEOS) 781 #if defined(OS_CHROMEOS)
784 display_color_manager_.reset(); 782 display_color_manager_.reset();
785 if (display_change_observer_) 783 if (display_change_observer_)
786 display_configurator_->RemoveObserver(display_change_observer_.get()); 784 display_configurator_->RemoveObserver(display_change_observer_.get());
787 if (display_error_observer_) 785 if (display_error_observer_)
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 event_client_.reset(new EventClientImpl); 1007 event_client_.reset(new EventClientImpl);
1010 1008
1011 // This controller needs to be set before SetupManagedWindowMode. 1009 // This controller needs to be set before SetupManagedWindowMode.
1012 desktop_background_controller_.reset( 1010 desktop_background_controller_.reset(
1013 new DesktopBackgroundController(blocking_pool_)); 1011 new DesktopBackgroundController(blocking_pool_));
1014 user_wallpaper_delegate_.reset( 1012 user_wallpaper_delegate_.reset(
1015 wm_shell_->delegate()->CreateUserWallpaperDelegate()); 1013 wm_shell_->delegate()->CreateUserWallpaperDelegate());
1016 1014
1017 session_state_delegate_.reset( 1015 session_state_delegate_.reset(
1018 wm_shell_->delegate()->CreateSessionStateDelegate()); 1016 wm_shell_->delegate()->CreateSessionStateDelegate());
1019 accessibility_delegate_.reset(
1020 wm_shell_->delegate()->CreateAccessibilityDelegate());
1021 new_window_delegate_.reset(wm_shell_->delegate()->CreateNewWindowDelegate()); 1017 new_window_delegate_.reset(wm_shell_->delegate()->CreateNewWindowDelegate());
1022 pointer_watcher_delegate_ = 1018 pointer_watcher_delegate_ =
1023 wm_shell_->delegate()->CreatePointerWatcherDelegate(); 1019 wm_shell_->delegate()->CreatePointerWatcherDelegate();
1024 1020
1025 resize_shadow_controller_.reset(new ResizeShadowController()); 1021 resize_shadow_controller_.reset(new ResizeShadowController());
1026 shadow_controller_.reset(new ::wm::ShadowController(activation_client_)); 1022 shadow_controller_.reset(new ::wm::ShadowController(activation_client_));
1027 1023
1028 wm_shell_->SetSystemTrayDelegate( 1024 wm_shell_->SetSystemTrayDelegate(
1029 base::WrapUnique(wm_shell_->delegate()->CreateSystemTrayDelegate())); 1025 base::WrapUnique(wm_shell_->delegate()->CreateSystemTrayDelegate()));
1030 1026
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
1168 1164
1169 void Shell::OnWindowActivated( 1165 void Shell::OnWindowActivated(
1170 aura::client::ActivationChangeObserver::ActivationReason reason, 1166 aura::client::ActivationChangeObserver::ActivationReason reason,
1171 aura::Window* gained_active, 1167 aura::Window* gained_active,
1172 aura::Window* lost_active) { 1168 aura::Window* lost_active) {
1173 if (gained_active) 1169 if (gained_active)
1174 target_root_window_ = gained_active->GetRootWindow(); 1170 target_root_window_ = gained_active->GetRootWindow();
1175 } 1171 }
1176 1172
1177 } // namespace ash 1173 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698