Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 2154513002: [Chromecast] Add cast event to log resource dispatcher network errors. (Closed)

Created:
4 years, 5 months ago by ejason
Modified:
4 years, 5 months ago
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Add cast event to log resource dispatcher network errors. BUG= internal b/30144624 Committed: https://crrev.com/2f73988b88f6d61f7671ea599b5cac346053dda6 Cr-Commit-Position: refs/heads/master@{#406031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chromecast/browser/cast_resource_dispatcher_host_delegate.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
ejason
4 years, 5 months ago (2016-07-14 22:40:46 UTC) #3
ejason
Friendly ping. I'd like to get this metric into the teamfood build before Tuesday.
4 years, 5 months ago (2016-07-18 13:02:32 UTC) #5
alokp
lgtm
4 years, 5 months ago (2016-07-18 16:37:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154513002/1
4 years, 5 months ago (2016-07-18 16:39:58 UTC) #9
derekjchow1
lgtm
4 years, 5 months ago (2016-07-18 16:50:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 17:56:07 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 17:56:09 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 17:58:24 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f73988b88f6d61f7671ea599b5cac346053dda6
Cr-Commit-Position: refs/heads/master@{#406031}

Powered by Google App Engine
This is Rietveld 408576698