fpdfsdk/javascript/app.cpp - Issue 2154503002: Remove type info from CJS_Value, interrogate v8 instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/app.cpp

Issue 2154503002: Remove type info from CJS_Value, interrogate v8 instead (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/app.cpp

diff --git a/fpdfsdk/javascript/app.cpp b/fpdfsdk/javascript/app.cpp

index dd706ebd8c862fe3255d3d887432101cbcc41c60..10776292442dd5b798112ecfe316bcd4af629f2f 100644

--- a/fpdfsdk/javascript/app.cpp

+++ b/fpdfsdk/javascript/app.cpp

@@ -458,7 +458,7 @@ FX_BOOL app::clearInterval(IJS_Context* cc,

}

void app::ClearTimerCommon(const CJS_Value& param) {

- if (param.GetType() != CJS_Value::VT_fxobject)

+ if (param.GetType() != CJS_Value::VT_object)

return;

v8::Local<v8::Object> pObj = param.ToV8Object();

« no previous file with comments | « fpdfsdk/javascript/JS_Value.cpp ('k') | fpdfsdk/javascript/global.cpp » ('j') | no next file with comments »