Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2154483002: X11: Cancel delayed resize task on manual resize (Closed)

Created:
4 years, 5 months ago by Tom (Use chromium acct)
Modified:
4 years, 5 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

X11: Cancel delayed resize task on manual resize This fixes a race condition where: 1. We get a ConfigureNotify event that tells us the window was resized and as a result post a delayed resize task 2. The window is resized 3. The delayed resize task runs and resizes the window to the old size The symptom experienced by this bug could be seen with tooltips which reuse the same window for each tooltip. If a window was resized to be larger, we would only render in the smaller area and garbage data would fill the rest. BUG=442111 Committed: https://crrev.com/7c6709e2148bd43c2f77396606a94fb6e0f8e78c Cr-Commit-Position: refs/heads/master@{#406043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Tom (Use chromium acct)
4 years, 5 months ago (2016-07-14 21:05:53 UTC) #4
Elliot Glaysher
lgtm
4 years, 5 months ago (2016-07-18 17:27:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154483002/1
4 years, 5 months ago (2016-07-18 17:41:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 18:30:27 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 18:30:44 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 18:33:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c6709e2148bd43c2f77396606a94fb6e0f8e78c
Cr-Commit-Position: refs/heads/master@{#406043}

Powered by Google App Engine
This is Rietveld 408576698