Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2154453002: Add runtime/bin/thread_fuchsia that binds to fuchsia's pthreads (Closed)

Created:
4 years, 5 months ago by jamesr
Modified:
4 years, 5 months ago
Reviewers:
zra
CC:
abarth-chromium, reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk/@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add runtime/bin/thread_fuchsia that binds to fuchsia's pthreads Fuchsia provides pthreads so the linux implementation almost works except that fuchsia does not (currently) provide the clock_gettime clock for CLOCK_THREAD_CPUTIME_ID. Committed: https://github.com/dart-lang/sdk/commit/0fae54022378e06920f6156a769f054fa1c6e3ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M runtime/bin/builtin_impl_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/thread.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + runtime/bin/thread_fuchsia.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/bin/thread_fuchsia.cc View 3 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jamesr
4 years, 5 months ago (2016-07-14 20:04:56 UTC) #2
jamesr
I think this *might* break the gyp build, but I don't have a way to ...
4 years, 5 months ago (2016-07-14 20:05:21 UTC) #3
zra
4 years, 5 months ago (2016-07-14 22:25:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0fae54022378e06920f6156a769f054fa1c6e3ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698