Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2154413002: Converted Observatory view-footer element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak, Cutch
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Splitted attached and detached in multiple lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -53 lines) Patch
M runtime/observatory/lib/elements.dart View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/code_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/context_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/error_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/field_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/flag_list.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/function_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/heap_map.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/heap_profile.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/logging.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/objectstore_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/script_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/view_footer.dart View 1 1 chunk +45 lines, -5 lines 0 comments Download
D runtime/observatory/lib/src/elements/view_footer.html View 1 chunk +0 lines, -23 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/observatory_sources.gypi View 2 chunks +4 lines, -1 line 0 comments Download
A runtime/observatory/tests/observatory_ui/view_footer/element_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/view_footer/element_test.html View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-18 20:48:18 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2154413002/diff/1/runtime/observatory/lib/src/elements/view_footer.dart File runtime/observatory/lib/src/elements/view_footer.dart (right): https://codereview.chromium.org/2154413002/diff/1/runtime/observatory/lib/src/elements/view_footer.dart#newcode31 runtime/observatory/lib/src/elements/view_footer.dart:31: void attached() { super.attached(); _r.enable(); } split to ...
4 years, 5 months ago (2016-07-18 23:19:17 UTC) #3
cbernaschina
https://codereview.chromium.org/2154413002/diff/1/runtime/observatory/lib/src/elements/view_footer.dart File runtime/observatory/lib/src/elements/view_footer.dart (right): https://codereview.chromium.org/2154413002/diff/1/runtime/observatory/lib/src/elements/view_footer.dart#newcode31 runtime/observatory/lib/src/elements/view_footer.dart:31: void attached() { super.attached(); _r.enable(); } On 2016/07/18 23:19:16, ...
4 years, 5 months ago (2016-07-18 23:22:37 UTC) #4
Cutch
lgtm
4 years, 5 months ago (2016-07-19 14:11:02 UTC) #5
cbernaschina
4 years, 5 months ago (2016-07-19 16:43:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
250f2a92a4e6f10fedcde284dd45bb9159068b4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698