Take the navigation type into account when checking if the navigation is in page.

content/browser/web_contents/navigation_controller_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_CONTROLLER_IMPL_H_
 #define CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_CONTROLLER_IMPL_H_
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
@@ skipping 136 matching lines @@
   // not compare it against the "active entry" since the active entry can be
   // pending and in page navigations only happen on committed pages. If there
   // is no last committed entry, then nothing will be in-page.
   //
   // Special note: if the URLs are the same, it does NOT automatically count as
   // an in-page navigation. Neither does an input URL that has no ref, even if
   // the rest is the same. This may seem weird, but when we're considering
   // whether a navigation happened without loading anything, the same URL could
   // be a reload, while only a different ref would be in-page (pages can't clear
   // refs without reload, only change to "#" which we don't count as empty).
-  bool IsURLInPageNavigation(const GURL& url) const {
-    return IsURLInPageNavigation(url, false);
+  bool IsURLInPageNavigation(const GURL& url,
+      content::NavigationType navigation_type) const {

[Charlie Reis, 2013/08/06 18:48:08]

We can leave this as a one-argument function that takes in url and passes
UNKNOWN as the type.

+    return IsURLInPageNavigation(url, false, navigation_type);
   }
 
   // The situation is made murkier by history.replaceState(), which could
   // provide the same URL as part of an in-page navigation, not a reload. So
   // we need this form which lets the (untrustworthy) renderer resolve the
   // ambiguity, but only when the URLs are equal. This should be safe since the
   // origin isn't changing.
-  bool IsURLInPageNavigation(const GURL& url, bool renderer_says_in_page) const;
+  bool IsURLInPageNavigation(const GURL& url, bool renderer_says_in_page,
+      content::NavigationType navigation_type) const;

[Charlie Reis, 2013/08/06 18:48:08]

Style nit: if all arguments can't fit on the same line, they should all be on
their own line.  See RendererDidNavigate for an example.

 
   // Sets the SessionStorageNamespace for the given |partition_id|. This is
   // used during initialization of a new NavigationController to allow
   // pre-population of the SessionStorageNamespace objects. Session restore,
   // prerendering, and the implementaion of window.open() are the primary users
   // of this API.
   //
   // Calling this function when a SessionStorageNamespace has already been
   // associated with a |partition_id| will CHECK() fail.
   void SetSessionStorageNamespace(
@@ skipping 220 matching lines @@
   TimeSmoother time_smoother_;
 
   scoped_ptr<WebContentsScreenshotManager> screenshot_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_CONTROLLER_IMPL_H_