Take the navigation type into account when checking if the navigation is in page.

content/browser/web_contents/navigation_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/navigation_controller_impl.h"
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"  // Temporary
@@ skipping 740 matching lines @@
     case NAVIGATION_TYPE_NEW_PAGE:
       RendererDidNavigateToNewPage(params, details->did_replace_entry);
       break;
     case NAVIGATION_TYPE_EXISTING_PAGE:
       RendererDidNavigateToExistingPage(params);
       break;
     case NAVIGATION_TYPE_SAME_PAGE:
       RendererDidNavigateToSamePage(params);
       break;
     case NAVIGATION_TYPE_IN_PAGE:
+      // When navigating back from a ref URL to the top non ref one is_in_page
+      // is false (see AreURLsInPageNavigation()). In order to set the flag
+      // properly take the navigation type into account as well.
+      details->is_in_page = true;

[Charlie Reis, 2013/08/05 22:18:10]

Putting it here doesn't help other callers of IsURLInPageNavigation or
AreURLsInPageNavigation.  Those functions will still return the wrong thing for
the "back to non-ref" case.

Maybe you can move the IsURLInPageNavigation call after ClassifyNavigation and
pass in details->type?  That might let us resolve jcampan's TODO statement in
AreURLsInPageNavigation.  We could default to passing in NAVIGATION_TYPE_UNKNOWN
if we don't have the type.

       RendererDidNavigateInPage(params, &details->did_replace_entry);
       break;
     case NAVIGATION_TYPE_NEW_SUBFRAME:
       RendererDidNavigateNewSubframe(params);
       break;
     case NAVIGATION_TYPE_AUTO_SUBFRAME:
       if (!RendererDidNavigateAutoSubframe(params))
         return false;
       break;
     case NAVIGATION_TYPE_NAV_IGNORE:
@@ skipping 913 matching lines @@
     }
   }
 }
 
 void NavigationControllerImpl::SetGetTimestampCallbackForTest(
     const base::Callback<base::Time()>& get_timestamp_callback) {
   get_timestamp_callback_ = get_timestamp_callback;
 }
 
 }  // namespace content