Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2154383002: Remove build-type arg from Chromedriver tests. (Closed)

Created:
4 years, 5 months ago by mikecase (-- gone --)
Modified:
4 years, 5 months ago
Reviewers:
samuong, jbudorick
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Remove build-type arg from Chromedriver tests. This isn't a valid arg for the Chromedriver test scripts and doesn't appear to be needed. Removing usage of --build-type BUG=627633 Committed: https://chromium.googlesource.com/chromium/tools/build/+/e5ad31e506abf607dce876b8cd6bb77e41659a05

Patch Set 1 #

Messages

Total messages: 10 (4 generated)
mikecase (-- gone --)
4 years, 5 months ago (2016-07-18 18:40:44 UTC) #2
mikecase (-- gone --)
4 years, 5 months ago (2016-07-18 19:48:00 UTC) #4
jbudorick
lgtm
4 years, 5 months ago (2016-07-18 19:49:56 UTC) #5
samuong
lgtm
4 years, 5 months ago (2016-07-18 19:50:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154383002/1
4 years, 5 months ago (2016-07-18 20:01:45 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 20:05:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/e5ad31e506abf607dce8...

Powered by Google App Engine
This is Rietveld 408576698