Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2154373002: Limit Skia to ES2 functionality in GLES2Interface/Skia bindings (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org, xidachen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit Skia to ES2 functionality in GLES2Interface/Skia bindings. The ES3 implementation is not currently well tested enough to enable Skia's use of it. However, Skia is required to run the WebGL2 conformance tests. To work around this conundrum we'll temporarily limit Skia to using ES2 functionality within an ES3 context. BUG=626431 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/9284cb85c1b67bd20a2ecfec90d30a397a044356 Cr-Commit-Position: refs/heads/master@{#406107}

Patch Set 1 #

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc View 1 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
bsalomon
PTAL
4 years, 5 months ago (2016-07-18 19:27:29 UTC) #5
no sievers
lgtm
4 years, 5 months ago (2016-07-18 19:49:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154373002/20001
4 years, 5 months ago (2016-07-18 19:51:37 UTC) #8
Ken Russell (switch to Gerrit)
Thanks Brian for this workaround. Going forward let's not forget to try to run Skia ...
4 years, 5 months ago (2016-07-18 21:15:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 21:44:09 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 21:44:20 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:46:20 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9284cb85c1b67bd20a2ecfec90d30a397a044356
Cr-Commit-Position: refs/heads/master@{#406107}

Powered by Google App Engine
This is Rietveld 408576698