Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
215433003:
[MediaGalleries] Update overall package doc to include iphoto paragraph. (Closed)
|
Created:
6 years, 9 months ago by Greg Billock Modified:
6 years, 9 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
Description[MediaGalleries] Update overall package doc to include iphoto paragraph.
R=vandebo@chromium.org
BUG=343968
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260273
Patch Set 1 #
Total comments: 4
Patch Set 2 : update #
Total comments: 4
Patch Set 3 : more breaks #
Total comments: 1
Messages
Total messages: 13 (0 generated)
LGTM https://codereview.chromium.org/215433003/diff/1/chrome/common/extensions/doc... File chrome/common/extensions/docs/templates/intros/mediaGalleries.html (right): https://codereview.chromium.org/215433003/diff/1/chrome/common/extensions/doc... chrome/common/extensions/docs/templates/intros/mediaGalleries.html:136: subdirectory, each album in the user's iPhoto library will appear by name, Is it possible for two albums to have to same name and if so what happens in that case? https://codereview.chromium.org/215433003/diff/1/chrome/common/extensions/doc... chrome/common/extensions/docs/templates/intros/mediaGalleries.html:137: and contain the entries for the photos in that album. Any duplicate album Does this mean? "Items that appear in multiple albums in iPhoto will also appear is multiple albums in the gallery."
https://codereview.chromium.org/215433003/diff/1/chrome/common/extensions/doc... File chrome/common/extensions/docs/templates/intros/mediaGalleries.html (right): https://codereview.chromium.org/215433003/diff/1/chrome/common/extensions/doc... chrome/common/extensions/docs/templates/intros/mediaGalleries.html:136: subdirectory, each album in the user's iPhoto library will appear by name, On 2014/03/28 15:31:08, vandebo wrote: > Is it possible for two albums to have to same name and if so what happens in > that case? Yes, two albums can have the same name. I forgot the sentence about the "(NN)" suffix we add then. Fixed. https://codereview.chromium.org/215433003/diff/1/chrome/common/extensions/doc... chrome/common/extensions/docs/templates/intros/mediaGalleries.html:137: and contain the entries for the photos in that album. Any duplicate album On 2014/03/28 15:31:08, vandebo wrote: > Does this mean? "Items that appear in multiple albums in iPhoto will also appear > is multiple albums in the gallery." Done.
On 2014/03/28 18:06:30, Greg Billock wrote: > https://codereview.chromium.org/215433003/diff/1/chrome/common/extensions/doc... > File chrome/common/extensions/docs/templates/intros/mediaGalleries.html (right): > > https://codereview.chromium.org/215433003/diff/1/chrome/common/extensions/doc... > chrome/common/extensions/docs/templates/intros/mediaGalleries.html:136: > subdirectory, each album in the user's iPhoto library will appear by name, > On 2014/03/28 15:31:08, vandebo wrote: > > Is it possible for two albums to have to same name and if so what happens in > > that case? > > Yes, two albums can have the same name. I forgot the sentence about the "(NN)" > suffix we add then. Fixed. > > https://codereview.chromium.org/215433003/diff/1/chrome/common/extensions/doc... > chrome/common/extensions/docs/templates/intros/mediaGalleries.html:137: and > contain the entries for the photos in that album. Any duplicate album > On 2014/03/28 15:31:08, vandebo wrote: > > Does this mean? "Items that appear in multiple albums in iPhoto will also > appear > > is multiple albums in the gallery." > > Done. +kalman owners
Meggin for a 2nd opinion at some point. https://codereview.chromium.org/215433003/diff/20001/chrome/common/extensions... File chrome/common/extensions/docs/templates/intros/mediaGalleries.html (right): https://codereview.chromium.org/215433003/diff/20001/chrome/common/extensions... chrome/common/extensions/docs/templates/intros/mediaGalleries.html:145: be the one the user has invested time cropping, rotating, or otherwise editing. this is a pretty large block of text: https://chrome-apps-doc.appspot.com/_patch/215433003/apps/mediaGalleries#iPhoto but then again so are the others. perhaps look at a paragraph break or two here. also is there some external documentation to link to?
(lgtm)
https://codereview.chromium.org/215433003/diff/20001/chrome/common/extensions... File chrome/common/extensions/docs/templates/intros/mediaGalleries.html (right): https://codereview.chromium.org/215433003/diff/20001/chrome/common/extensions... chrome/common/extensions/docs/templates/intros/mediaGalleries.html:145: be the one the user has invested time cropping, rotating, or otherwise editing. On 2014/03/28 18:19:00, kalman wrote: > this is a pretty large block of text: > > https://chrome-apps-doc.appspot.com/_patch/215433003/apps/mediaGalleries#iPhoto > > but then again so are the others. perhaps look at a paragraph break or two here. ok > > also is there some external documentation to link to? sadly, no
The CQ bit was checked by gbillock@chromium.org
lgtm that looks much better thanks.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/215433003/40001
https://codereview.chromium.org/215433003/diff/40001/chrome/common/extensions... File chrome/common/extensions/docs/templates/intros/mediaGalleries.html (right): https://codereview.chromium.org/215433003/diff/40001/chrome/common/extensions... chrome/common/extensions/docs/templates/intros/mediaGalleries.html:141: <p>Duplicate album names or image filenames with albums will get a with -> within ?
Message was sent while issue was closed.
Change committed as 260273
Message was sent while issue was closed.
https://codereview.chromium.org/215433003/diff/20001/chrome/common/extensions... File chrome/common/extensions/docs/templates/intros/mediaGalleries.html (right): https://codereview.chromium.org/215433003/diff/20001/chrome/common/extensions... chrome/common/extensions/docs/templates/intros/mediaGalleries.html:140: albums in iPhoto will appear in all those albums in the gallery. If the user From 'If' onwards could use some editing. Crazy sentences. Also, I don't think the last sentence is necessary. How about something like: If the user modifies any image within an album, a subdirectory called "originals/" is added to the album directory. The "originals/" subdirectory contains a copy of the modified image with the same filename. https://codereview.chromium.org/215433003/diff/20001/chrome/common/extensions... chrome/common/extensions/docs/templates/intros/mediaGalleries.html:145: be the one the user has invested time cropping, rotating, or otherwise editing. Agree with kalman, that this could use some paragraph breaks. On 2014/03/28 18:19:00, kalman wrote: > this is a pretty large block of text: > > https://chrome-apps-doc.appspot.com/_patch/215433003/apps/mediaGalleries#iPhoto > > but then again so are the others. perhaps look at a paragraph break or two here. > > also is there some external documentation to link to? |
