Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2154323002: [ash-md] Fixes z-order to get context menus above overview items (Closed)

Created:
4 years, 5 months ago by varkha
Modified:
4 years, 5 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Fixes z-order to get context menus above overview items Changes the parent of search widget labels and close buttons in overview mode to be kShellWindowId_StatusContainer which is still above all windows but below menus and screen overlays. BUG=629039 Committed: https://crrev.com/4aef838caffce4c0c9701c0f907ce826b30b7907 Cr-Commit-Position: refs/heads/master@{#406040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ash/common/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/overview/window_selector_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
varkha
tdanderson@, can you please take a look? Thanks!
4 years, 5 months ago (2016-07-18 16:54:23 UTC) #3
tdanderson
lgtm
4 years, 5 months ago (2016-07-18 18:10:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154323002/1
4 years, 5 months ago (2016-07-18 18:11:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 18:16:42 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 18:16:48 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 18:18:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4aef838caffce4c0c9701c0f907ce826b30b7907
Cr-Commit-Position: refs/heads/master@{#406040}

Powered by Google App Engine
This is Rietveld 408576698