Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2154303003:
Add Media Router mojo/ sub-directory OWNERS for type converters. (Closed)
|
Created:
4 years, 5 months ago by Wez Modified:
4 years, 5 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, media-router+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd Media Router mojo/ sub-directory OWNERS for type converters.
Both Mojom interfaces and Mojo type-converters need security review.
Committed: https://crrev.com/c1ea8bfed66ea87975bd211ba15c261312813b6b
Cr-Commit-Position: refs/heads/master@{#406750}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Rebase #Messages
Total messages: 25 (15 generated)
wez@chromium.org changed reviewers: + apacible@chromium.org, dcheng@chromium.org
apacible: OWNERS, plz dcheng: Sanity-check that this is what we need here. :)
The CQ bit was checked by wez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2154303003/diff/1/chrome/browser/media/router... File chrome/browser/media/router/mojo/OWNERS (right): https://codereview.chromium.org/2154303003/diff/1/chrome/browser/media/router... chrome/browser/media/router/mojo/OWNERS:1: # Changes to Mojo interfaces or types need SECURITY_OWNERS approval. The other */mojo/OWNERS files don't have this comment. Maybe remove this for consistency?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Looks like you'll have to pull again to pick up https://codereview.chromium.org/2111303003/.
Description was changed from ========== Add Media Router mojo/ sub-directory OWNERS. .mojom and type-converter implementations need SECURITY_OWNERS approval, which only works if the OWNERS file is correctly set up. ========== to ========== Add Media Router mojo/ sub-directory OWNERS for type converters. Both Mojom interfaces and Mojo type-converters need security review. ==========
The CQ bit was checked by wez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL :)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
imcheng@chromium.org changed reviewers: + imcheng@chromium.org
lgtm
LGTM
On 2016/07/19 at 01:31:44, dcheng wrote: > LGTM Hitting commit as this is blocking other changes from being committed ATM.
The CQ bit was checked by mfoltz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from apacible@chromium.org Link to the patchset: https://codereview.chromium.org/2154303003/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add Media Router mojo/ sub-directory OWNERS for type converters. Both Mojom interfaces and Mojo type-converters need security review. ========== to ========== Add Media Router mojo/ sub-directory OWNERS for type converters. Both Mojom interfaces and Mojo type-converters need security review. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add Media Router mojo/ sub-directory OWNERS for type converters. Both Mojom interfaces and Mojo type-converters need security review. ========== to ========== Add Media Router mojo/ sub-directory OWNERS for type converters. Both Mojom interfaces and Mojo type-converters need security review. Committed: https://crrev.com/c1ea8bfed66ea87975bd211ba15c261312813b6b Cr-Commit-Position: refs/heads/master@{#406750} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c1ea8bfed66ea87975bd211ba15c261312813b6b Cr-Commit-Position: refs/heads/master@{#406750} |
