Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2154303002: Reland: Measure whether muted videos that started playing with play() become visible at some point (Closed)

Created:
4 years, 5 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, nessy, feature-media-reviews_chromium.org, posciak+watch_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, abarth-chromium, mlamouri+watch-blink_chromium.org, dglazkov+blink, asvitkine+watch_chromium.org, blink-reviews, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Measure whether muted videos that started playing with play() become visible at some point Relanding previous CL (https://codereview.chromium.org/2108403003) after the memory leak and crash have been fixed. Marking as TBR since the previous CL has already been reviewed. BUG=622720 TBR=haraken@chromium.org,mlamouri@chromium.org,rkaplow@chromium.org Committed: https://crrev.com/061ad2b0252c21ba4adf49f6cd8ba63db1e89b02 Cr-Commit-Position: refs/heads/master@{#412214}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -46 lines) Patch
M third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/html/AutoplayUmaHelper.h View 1 chunk +70 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp View 1 chunk +130 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 4 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 9 chunks +8 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/html/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154303002/20001
4 years, 4 months ago (2016-08-16 11:29:39 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 11:34:35 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 11:36:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/061ad2b0252c21ba4adf49f6cd8ba63db1e89b02
Cr-Commit-Position: refs/heads/master@{#412214}

Powered by Google App Engine
This is Rietveld 408576698