Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2348)

Unified Diff: chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Issue 2154263004: [MD Settings] Lazy create dialogs in Passwords and Autofill section. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback 2.0 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js b/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
index c74d561161d25c81e51267e9870b9cd399b582f5..dd22d9b5668c1fc372a55076f89ea9d2d5a3a8f7 100644
--- a/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
@@ -362,55 +362,11 @@ TEST_F('SettingsPasswordSectionBrowserTest', 'uiTests', function() {
clickRemoveButton();
});
- test('usePasswordDialogTwice', function() {
- var BLANK_PASSWORD = ' ';
- var item = FakeDataMaker.passwordEntry('google.com', 'homer',
- BLANK_PASSWORD.length);
- var passwordDialog = self.createPasswordDialog_(item);
-
- passwordDialog.open();
- Polymer.dom.flush();
-
- assertEquals(item.loginPair.originUrl,
- passwordDialog.$.websiteInput.value);
- assertEquals(item.loginPair.username,
- passwordDialog.$.usernameInput.value);
- assertEquals(BLANK_PASSWORD,
- passwordDialog.$.passwordInput.value);
- // Password should NOT be visible.
- assertEquals('password',
- passwordDialog.$.passwordInput.type);
-
- passwordDialog.close();
- Polymer.dom.flush();
-
- var blankPassword2 = ' '.repeat(17);
- var item2 = FakeDataMaker.passwordEntry('drive.google.com', 'marge',
- blankPassword2.length);
-
- passwordDialog.item = item2;
- passwordDialog.open();
- Polymer.dom.flush();
-
- assertEquals(item2.loginPair.originUrl,
- passwordDialog.$.websiteInput.value);
- assertEquals(item2.loginPair.username,
- passwordDialog.$.usernameInput.value);
- assertEquals(blankPassword2,
- passwordDialog.$.passwordInput.value);
- // Password should NOT be visible.
- assertEquals('password',
- passwordDialog.$.passwordInput.type);
- });
-
test('showSavedPassword', function() {
var PASSWORD = 'bAn@n@5';
var item = FakeDataMaker.passwordEntry('goo.gl', 'bart', PASSWORD.length);
var passwordDialog = self.createPasswordDialog_(item);
- passwordDialog.open();
- Polymer.dom.flush();
-
passwordDialog.password = PASSWORD;
passwordDialog.showPassword = true;
@@ -428,9 +384,6 @@ TEST_F('SettingsPasswordSectionBrowserTest', 'uiTests', function() {
var item = FakeDataMaker.passwordEntry('goo.gl', 'bart', 1);
var passwordDialog = self.createPasswordDialog_(item);
- passwordDialog.open();
- Polymer.dom.flush();
-
passwordDialog.addEventListener('show-password', function(event) {
assertEquals(item.loginPair.originUrl, event.detail.originUrl);
assertEquals(item.loginPair.username, event.detail.username);

Powered by Google App Engine
This is Rietveld 408576698