Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html

Issue 2154263004: [MD Settings] Lazy create dialogs in Passwords and Autofill section. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback 2.0 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
index 2632a0eb3ecbfd2f9b6575fd3bd044cfead85965..8092277f5a76c512a209acbef5783d218328525e 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
@@ -68,8 +68,11 @@
<button id="menuRemoveAddress" class="list-item menu-item"
on-tap="onMenuRemoveAddressTap_">$i18n{removeAddress}</button>
</cr-shared-menu>
- <settings-address-edit-dialog id="addressEditDialog">
- </settings-address-edit-dialog>
+ <template is="dom-if" if="[[activeAddress]]" restamp>
+ <settings-address-edit-dialog address="[[activeAddress]]"
+ on-iron-overlay-closed="unstampAddressEditDialog_">
+ </settings-address-edit-dialog>
+ </template>
<div class="heading">$i18n{creditCards}</div>
<div class="item-list">
<div class="list-item column-header">
@@ -116,8 +119,11 @@
<button id="menuClearCreditCard" class="list-item menu-item"
on-tap="onMenuClearCreditCardTap_">$i18n{clearCreditCard}</button>
</cr-shared-menu>
- <settings-credit-card-edit-dialog id="editCreditCardDialog">
- </settings-credit-card-edit-dialog>
+ <template is="dom-if" if="[[activeCreditCard]]" restamp>
+ <settings-credit-card-edit-dialog credit-card="[[activeCreditCard]]"
+ on-iron-overlay-closed="unstampCreditCardEditDialog_">
+ </settings-credit-card-edit-dialog>
+ </template>
</template>
<link rel="import" type="css" href="chrome://resources/css/action_link.css">
<script src="/passwords_and_forms_page/autofill_section.js"></script>

Powered by Google App Engine
This is Rietveld 408576698