[MD Settings] Lazy create dialogs in Passwords and Autofill section.

chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Runs the Polymer Autofill Settings tests. */
 
 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
 var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
@@ skipping 146 matching lines @@
 
   /**
    * Creates the Edit Address dialog and fulfills the promise when the dialog
    * has actually opened.
    * @param {!chrome.autofillPrivate.AddressEntry} address
    * @return {!Promise<Object>}
    */
   createAddressDialog_: function(address) {
     return new Promise(function(resolve) {
       var section = document.createElement('settings-address-edit-dialog');
+      section.address = address;
       document.body.appendChild(section);
-      var onOpen = function() {
+      section.addEventListener('iron-overlay-opened', function() {
         resolve(section);
-      };
-      section.addEventListener('iron-overlay-opened', onOpen);
-
-      // |setTimeout| allows the dialog to async get the list of countries
-      // before running any tests.
-      window.setTimeout(function() {
-        section.open(address);  // Opening the dialog will add the item.
-        Polymer.dom.flush();
-      }, 0);
+      });
     });
   },
 
   /**
    * Creates the Edit Credit Card dialog.
    * @param {!chrome.autofillPrivate.CreditCardEntry} creditCardItem
    * @return {!Object}
    */
   createCreditCardDialog_: function(creditCardItem) {
     var section = document.createElement('settings-credit-card-edit-dialog');
+    section.creditCard = creditCardItem;
     document.body.appendChild(section);
-    section.open(creditCardItem);  // Opening the dialog will add the item.
     Polymer.dom.flush();
     return section;
   },
 };
 
 TEST_F('SettingsAutofillSectionBrowserTest', 'CreditCardTests', function() {
   var self = this;
 
   suite('AutofillSection', function() {
     test('verifyCreditCardCount', function() {
@@ skipping 211 matching lines @@
 
         assertEquals('', dialog.$.emailInput.value);
         assertFalse(!!(address.emailAddresses && address.emailAddresses[0]));
 
         var phoneNumber = '(555) 555-5555';
         var emailAddress = 'no-reply@chromium.org';
 
         dialog.$.phoneInput.value = phoneNumber;
         dialog.$.emailInput.value = emailAddress;
 
-        Polymer.dom.flush();
+        return expectEvent(dialog, 'save-address', function() {
+          MockInteractions.tap(dialog.$.saveButton);
+        }).then(function() {
+          assertEquals(phoneNumber, dialog.$.phoneInput.value);
+          assertEquals(phoneNumber, address.phoneNumbers[0]);
 
-        assertEquals(phoneNumber, dialog.$.phoneInput.value);
-        assertEquals(phoneNumber, address.phoneNumbers[0]);
-
-        assertEquals(emailAddress, dialog.$.emailInput.value);
-        assertEquals(emailAddress, address.emailAddresses[0]);
+          assertEquals(emailAddress, dialog.$.emailInput.value);
+          assertEquals(emailAddress, address.emailAddresses[0]);
+        });
       });
     });
 
     test('verifyPhoneAndEmailAreRemoved', function() {
       var address = FakeDataMaker.emptyAddressEntry();
 
       var phoneNumber = '(555) 555-5555';
       var emailAddress = 'no-reply@chromium.org';
 
+      address.countryCode = 'US';  // Set to allow save to be active.
       address.phoneNumbers = [phoneNumber];
       address.emailAddresses = [emailAddress];
 
       return self.createAddressDialog_(address).then(function(dialog) {
         assertEquals(phoneNumber, dialog.$.phoneInput.value);
         assertEquals(emailAddress, dialog.$.emailInput.value);
 
         dialog.$.phoneInput.value = '';
         dialog.$.emailInput.value = '';
 
-        Polymer.dom.flush();
-
-        assertEquals(0, address.phoneNumbers.length);
-        assertEquals(0, address.emailAddresses.length);
+        return expectEvent(dialog, 'save-address', function() {
+          MockInteractions.tap(dialog.$.saveButton);
+        }).then(function() {
+          assertEquals(0, address.phoneNumbers.length);
+          assertEquals(0, address.emailAddresses.length);
+        });
       });
     });
 
     // Test will set a value of 'foo' in each text field and verify that the
     // save button is enabled, then it will clear the field and verify that the
     // save button is disabled. Test passes after all elements have been tested.
     test('verifySaveIsNotClickableIfAllInputFieldsAreEmpty', function() {
       return self.createAddressDialog_(
           FakeDataMaker.emptyAddressEntry()).then(function(dialog) {
         var saveButton = dialog.$.saveButton;
@@ skipping 304 matching lines @@
           assertEquals(city, cols[0].value);
           assertEquals(state, cols[1].value);
           assertEquals(zip, cols[2].value);
         });
       });
     });
   });
 
   mocha.run();
 });